From owner-freebsd-commit  Thu Apr  6 00:29:41 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id AAA13570
          for commit-outgoing; Thu, 6 Apr 1995 00:29:41 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id AAA13557
          for cvs-ports-outgoing; Thu, 6 Apr 1995 00:29:38 -0700
Received: from time.cdrom.com (time.cdrom.com [192.216.223.46])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA13550
          ; Thu, 6 Apr 1995 00:29:34 -0700
Received: from freefall.cdrom.com (freefall.cdrom.com [192.216.222.4]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id AAA11023; Thu, 6 Apr 1995 00:29:34 -0700
Received: from localhost (localhost [127.0.0.1])
          by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id AAA13543
          ; Thu, 6 Apr 1995 00:29:28 -0700
X-Authentication-Warning: freefall.cdrom.com: Host localhost didn't use HELO protocol
To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
cc: jkh@freebsd.org, CVS-commiters@time.cdrom.com, cvs-ports@time.cdrom.com,
        vode@snakemail.hut.fi
Subject: Re: cvs commit: ports/net/sup/patches patch-ae 
In-reply-to: Your message of "Wed, 05 Apr 95 23:34:18 PDT."
             <199504060634.XAA02561@gndrsh.aac.dev.com> 
Date: Thu, 06 Apr 1995 00:29:27 -0700
Message-ID: <13542.797153367@freefall.cdrom.com>
From: "Jordan K. Hubbard" <jkh@freefall.cdrom.com>
Sender: commit-owner@freebsd.org
Precedence: bulk

It's just _one_ patch file which can easily be moved out of the way or
deleted..  Jeeze - I've never seen this much interest in a ports
collection item from you before! ;-)

If there's enough consensus, I'll happily delete it.

					Jordan


> > 
> > > No man page updates for it :-(.
> > > No way to turn it off :-(.
> > > 
> > > And admitted hackery in the code:
> > > +       char rfname[1024];      /* Kludge alert.. */
> > 
> > 
> > 1. Sorry, I thought he'd changed the manpage.  I'll document it if he
> >    doesn't beat me to it.
> 
> That means you didn't even look at the patch close enough
> to know what files where patched.  How much of a review could that have
> really been :-(
> 
> > 2. You turn it off by not creating a file with the special name.. :-)
> 
> And double the number of stat calls made during the already slow sup :-(.
> 
> > 3. You would prefer that he simply not admit to the hackery? ;-)
> 
> No, I prefer that we not import hackery into our code base.  I am not
> the only one who is unhappy about these changes.
> 
> 
> 
> -- 
> Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
> Accurate Automation Company                   Custom computers for FreeBSD