From owner-svn-src-all@freebsd.org Fri May 4 22:58:22 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67C3AFBA8F7 for ; Fri, 4 May 2018 22:58:22 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC97C82D1C for ; Fri, 4 May 2018 22:58:21 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-lf0-x236.google.com with SMTP id g12-v6so33039823lfb.10 for ; Fri, 04 May 2018 15:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7LkSp2Mnc7UxVgMyQYZaBWGRngsvnB2JBt/htDOCHE4=; b=dIyVXXuO3ghNqTN28gv9Gdx9uZXmqor+rJ6nG7N3wJcd3rugd5UvZ6WyNH0Mbn7vA6 3EvgtrQ1Qd3AMyaPsScxzhSISnTrBFtWh5xtlUaZddQPchD527NnW4r1xCwoh+BgGVsF AhXoXNIX+AFb/1Yh07T8p5hUfq1jGToTA0DG95EVz76Lr+lpwhcHzomKfPrRLTYHCHAg meABOmhLQUAhZCMrDMM2z5tJhH7T0rS0Unpm2LuMKsa/OYgE8eHWldcpuRmks6kfNnOg PDGkmwerLVKibfGhgRI2fwbdgyH+Sg2nvH4/8zq8f/nBRkkYLxOZA+KJ/6CCQrgYGSPP TODw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7LkSp2Mnc7UxVgMyQYZaBWGRngsvnB2JBt/htDOCHE4=; b=s/Ud8YHJhhZB6DGNFmih4gp4ddoeG5cv1mBMOEP5HG3gYdy38nRwXGJlNAkndOqMPJ BM/t1fxtYe9xZeCl+mIUU64Ag/ihE9IxaCIL/nC/hlYbW7eLb66RDMmzTnps32pgq7sK o5MmcwyCOrfElrkX/z2TBTxNIKll2Rc1K+bEcj9vVINL3a4CpIp1/atOyCpQcVWzhDQr tDzPASAsf9jZye3GJKRC8DkOA4HXcWRHyy9JbBNYi+EkGu7++C6/Q3t3NCU8Y8yuNOJW jP4PbfSSa8ZaH4dBvXWto+7Rwf4M80VlggsVkxnexJrfH88VmNg48l2jnLBZJHM3cHwk Kq0A== X-Gm-Message-State: ALQs6tD3yTQ46uop60VdSCW7vljf76YoQKE152uCoUsw42pqNSVqMdlz Z4pdDtc3WW1XJ1lof5d8mOILpJ6qz/U6op830hkDKw== X-Google-Smtp-Source: AB8JxZoHxM1SI3Pl/pG8aMngTuQ+A8VE7ha66ThsdZpOSVYX8ecDKr+hFSe/tH6TxDfTOsloavPyjszi+6S07J2pI6E= X-Received: by 2002:a19:5209:: with SMTP id m9-v6mr17573475lfb.72.1525474700004; Fri, 04 May 2018 15:58:20 -0700 (PDT) MIME-Version: 1.0 References: <201805042241.w44MfC9E090893@repo.freebsd.org> In-Reply-To: <201805042241.w44MfC9E090893@repo.freebsd.org> From: Steven Hartland Date: Fri, 04 May 2018 22:58:09 +0000 Message-ID: Subject: Re: svn commit: r333266 - head/sys/amd64/amd64 To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 22:58:22 -0000 Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be obtained from reading the diff, which just leaves us wondering why? I=E2=80=99m sure there is a good reason, but without confirmation we=E2=80= =99re just left guessing. The knock on to this is if some assumption that caused the why changes, anyone looking at this will not be able to make an informed descision that that was the case. On Fri, 4 May 2018 at 23:41, Mateusz Guzik wrote: > Author: mjg > Date: Fri May 4 22:41:12 2018 > New Revision: 333266 > URL: https://svnweb.freebsd.org/changeset/base/333266 > > Log: > amd64: syscall path bcopy -> memcpy > > Modified: > head/sys/amd64/amd64/trap.c > > Modified: head/sys/amd64/amd64/trap.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/amd64/amd64/trap.c Fri May 4 22:33:54 2018 (r333265) > +++ head/sys/amd64/amd64/trap.c Fri May 4 22:41:12 2018 (r333266) > @@ -908,7 +908,7 @@ cpu_fetch_syscall_args(struct thread *td) > error =3D 0; > argp =3D &frame->tf_rdi; > argp +=3D reg; > - bcopy(argp, sa->args, sizeof(sa->args[0]) * 6); > + memcpy(sa->args, argp, sizeof(sa->args[0]) * 6); > if (sa->narg > regcnt) { > KASSERT(params !=3D NULL, ("copyin args with no params!")= ); > error =3D copyin(params, &sa->args[regcnt], > >