Date: Fri, 5 Mar 2021 19:23:56 +0100 From: Gordon Bergling <gbe@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 89b650872bba - main - ktls: Hide initialization message behind bootverbose Message-ID: <YEJ3PDT3oOX09z%2BY@lion.0xfce3.net> In-Reply-To: <202103051815.125IFDNK001016@gitrepo.freebsd.org> References: <202103051815.125IFDNK001016@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Mark, is this change not a little bit to aggressive in terms of dmesg cleanup? There are a lot messages about what subsystem is initialized with how many threads, like for example TCP HTPS and TCP BBR. Hiding this information could be suboptimal for some users. --Gordon On Fri, Mar 05, 2021 at 06:15:13PM +0000, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=89b650872bba2e4bfbc94a200946b461ef69ae22 > > commit 89b650872bba2e4bfbc94a200946b461ef69ae22 > Author: Mark Johnston <markj@FreeBSD.org> > AuthorDate: 2021-03-05 18:11:02 +0000 > Commit: Mark Johnston <markj@FreeBSD.org> > CommitDate: 2021-03-05 18:11:02 +0000 > > ktls: Hide initialization message behind bootverbose > > We don't typically print anything when a subsystem initializes itself, > and KTLS is currently disabled by default anyway. > > Reviewed by: jhb > MFC after: 1 week > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D29097 > --- > sys/kern/uipc_ktls.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/kern/uipc_ktls.c b/sys/kern/uipc_ktls.c > index 5125061e0879..1fd1eca39b59 100644 > --- a/sys/kern/uipc_ktls.c > +++ b/sys/kern/uipc_ktls.c > @@ -495,7 +495,8 @@ ktls_init(void *dummy __unused) > } > } > > - printf("KTLS: Initialized %d threads\n", ktls_number_threads); > + if (bootverbose) > + printf("KTLS: Initialized %d threads\n", ktls_number_threads); > } > SYSINIT(ktls, SI_SUB_SMP + 1, SI_ORDER_ANY, ktls_init, NULL); > > _______________________________________________ > dev-commits-src-main@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > To unsubscribe, send any mail to "dev-commits-src-main-unsubscribe@freebsd.org" --
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YEJ3PDT3oOX09z%2BY>