From nobody Thu Mar 5 22:06:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fRkC06S3Rz6TkrQ for ; Thu, 05 Mar 2026 22:06:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fRkC05xVXz3ChN for ; Thu, 05 Mar 2026 22:06:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772748380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8eYYdIora5mRhQx+nqSPT8XTGgp3sjo6DvJQR3i/E7g=; b=hRhEVRjRZYFHKnMkUQ3wkrFClT3FNUeDhW7c17HHEtS4kwfsvWRkzNL73rzjAEvOcZQXFK 0nB0PcI7CFT80HaBlEbrvb9rUY3lt4yCI05U/xP4zNBRBHFAqHCuK2NUpn6vaqejJU554B 5KR3DNetJUh9Q9MNbe10hKr6OLl6gXKfZgt1jRFZKumGAIW0Lzey5ijS9eaoM+b3TNEWgF VhnmtA+y03Yh28ODbxAt0utBeiIsmOnA2bjaFRogOStqRjmcDLdd8dicV0pUTdDheBQcN7 kwtY0KvSZTv+DpE0njNPR4d1259ZK/HqiIx2jTZsAV/2ZWrwn6GeIk8qnhi2ZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772748380; a=rsa-sha256; cv=none; b=JJO8f0B3dC1FkhraxojQNA+y3TnBcAGMr1Kcf62iwpGQU0uyB5uRW8HV0/ZsCekxzmHJc1 l/oGSiUCSHkKX70UiDT9fi78pP9XkTRap87azUDUJZTijUcvjJaOcmjQtFXNxL1JXUmxxV YiJGj83FnA427BakxLBDVYfW+b2RkBn1klbvdsswO5g/PS6nQsV9OfqpohDPwFCBXLbu8d lcGmgDkQ+gyH4nofqzdLw4t9apsKnJ3Q6NqTEQKX4tsjCBY8Et9Uw1vHxakXzx3HyE3jmP HwZ58ThoTsfZV9hbpiDG57w9OSBCzI2/eZCKzEMhDvTv4u7z/LRdfMGAurY72g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772748380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8eYYdIora5mRhQx+nqSPT8XTGgp3sjo6DvJQR3i/E7g=; b=neRRQT3AcZM3D34Z8aw4yWXyjtc34Wt9A+9TsF1qoLdWlG9uH6zxmU7+KTpURZl5D7lW9p GAWBo6VtzLSM9kcyLpQyQymZ2oEmEwVmqpNOrp1eWKFdzMB4wyavhnAOuBu+AIANadu6WE ZCNM8/3MzM0ZYFLNgnHXG7GQHAwIl61T+zxwaeUf3CFcImGR64WfXAhjYC40HkI/P2hzkh e7eDOVdgIfzD1+swKCv5tYlSrCFyIEL2lU+ZXZx6rDh5vgjCKbdrYECT8g0Fkeb0qB8//D RAw5BMxX/JxFe85SntzxDcBsG7kZLkRPozKOnq6nbtjZHmgcSn+PQCdCW7IJdg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fRkC059p6zw7V for ; Thu, 05 Mar 2026 22:06:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34787 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Mar 2026 22:06:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: b4269beda1b1 - stable/15 - iwx: Fix 32-bit compilation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: b4269beda1b1a64fab5c9a582a35b0bb2c688360 Auto-Submitted: auto-generated Date: Thu, 05 Mar 2026 22:06:15 +0000 Message-Id: <69a9fe57.34787.77af5135@gitrepo.freebsd.org> The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=b4269beda1b1a64fab5c9a582a35b0bb2c688360 commit b4269beda1b1a64fab5c9a582a35b0bb2c688360 Author: Olivier Certner AuthorDate: 2026-03-05 12:31:51 +0000 Commit: Olivier Certner CommitDate: 2026-03-05 22:05:42 +0000 iwx: Fix 32-bit compilation - Avoid shifts wider than integer types, by wrapping the corresponding checks into '#if __SIZEOF_SIZE_T__ > 32' blocks. 'bus_addr_t' currently has the same width as 'size_t' on all architectures (and this is not going to change for 32-bit architectures). - Use appropriate printf(3) format for 'wk_keytsc'. Reviewed by: adrian MFC after: 1 minute MFC to: stable/15 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D55667 (cherry picked from commit 35da55c28dbb56dd7056b7863efc5b547950d885) --- sys/dev/iwx/if_iwx.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/sys/dev/iwx/if_iwx.c b/sys/dev/iwx/if_iwx.c index 1fe531d69933..6d12de0753c0 100644 --- a/sys/dev/iwx/if_iwx.c +++ b/sys/dev/iwx/if_iwx.c @@ -155,6 +155,7 @@ #include #include +#include #include #include #include @@ -5775,15 +5776,21 @@ iwx_tx(struct iwx_softc *sc, struct mbuf *m, struct ieee80211_node *ni) desc->tbs[0].tb_len = htole16(IWX_FIRST_TB_SIZE); paddr = htole64(data->cmd_paddr); memcpy(&desc->tbs[0].addr, &paddr, sizeof(paddr)); - if (data->cmd_paddr >> 32 != (data->cmd_paddr + le32toh(desc->tbs[0].tb_len)) >> 32) +#if __SIZEOF_SIZE_T__ > 32 + if (data->cmd_paddr >> 32 != (data->cmd_paddr + + le32toh(desc->tbs[0].tb_len)) >> 32) DPRINTF(("%s: TB0 crosses 32bit boundary\n", __func__)); +#endif desc->tbs[1].tb_len = htole16(sizeof(struct iwx_cmd_header) + txcmd_size + hdrlen + pad - IWX_FIRST_TB_SIZE); paddr = htole64(data->cmd_paddr + IWX_FIRST_TB_SIZE); memcpy(&desc->tbs[1].addr, &paddr, sizeof(paddr)); - if (data->cmd_paddr >> 32 != (data->cmd_paddr + le32toh(desc->tbs[1].tb_len)) >> 32) +#if __SIZEOF_SIZE_T__ > 32 + if (data->cmd_paddr >> 32 != (data->cmd_paddr + + le32toh(desc->tbs[1].tb_len)) >> 32) DPRINTF(("%s: TB1 crosses 32bit boundary\n", __func__)); +#endif /* Other DMA segments are for data payload. */ for (i = 0; i < nsegs; i++) { @@ -5791,8 +5798,12 @@ iwx_tx(struct iwx_softc *sc, struct mbuf *m, struct ieee80211_node *ni) desc->tbs[i + 2].tb_len = htole16(seg->ds_len); paddr = htole64(seg->ds_addr); memcpy(&desc->tbs[i + 2].addr, &paddr, sizeof(paddr)); - if (data->cmd_paddr >> 32 != (data->cmd_paddr + le32toh(desc->tbs[i + 2].tb_len)) >> 32) - DPRINTF(("%s: TB%d crosses 32bit boundary\n", __func__, i + 2)); +#if __SIZEOF_SIZE_T__ > 32 + if (data->cmd_paddr >> 32 != (data->cmd_paddr + + le32toh(desc->tbs[i + 2].tb_len)) >> 32) + DPRINTF(("%s: TB%d crosses 32bit boundary\n", __func__, + i + 2)); +#endif } bus_dmamap_sync(ring->data_dmat, data->map, BUS_DMASYNC_PREWRITE); @@ -10987,7 +10998,7 @@ iwx_key_set(struct ieee80211vap *vap, const struct ieee80211_key *k) cmd.common.sta_id = IWX_STATION_ID; cmd.transmit_seq_cnt = htole64(k->wk_keytsc); - DPRINTF(("%s: k->wk_keytsc=%lu\n", __func__, k->wk_keytsc)); + DPRINTF(("%s: k->wk_keytsc=%" PRIu64 "\n", __func__, k->wk_keytsc)); status = IWX_ADD_STA_SUCCESS; err = iwx_send_cmd_pdu_status(sc, IWX_ADD_STA_KEY, sizeof(cmd), &cmd,