From owner-freebsd-current@freebsd.org Sun Nov 20 02:31:35 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DFCEDC3ECAA; Sun, 20 Nov 2016 02:31:35 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A753F1503; Sun, 20 Nov 2016 02:31:35 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-it0-x243.google.com with SMTP id o1so10931876ito.1; Sat, 19 Nov 2016 18:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bPSzWVIOz5/ECAvHbD2+qWropcS5v1a5C8wdu8b9VKo=; b=TLV8ihadlyHeaz0f9drIpGbuY1w5I7J6I36yTLAWuJ269Ziikxgb9beu/HNZCnuxaB y5u3sIhtycgf6tPnjMahPVaRxgE9Tao90IllR5Qwrdj/HC9jHPzrH1ZO8y0/HKdB0A8a JldeoFcUza+XV+zsvzUk/oI9C2o54CBtsCjp03KjKOeBx7dVYLwPuBDIgPUe2252wgLQ p5+XldR3rhmC8h0xtvWfIKUga3bp8QDoSTu+Ue3+Xc6Gfp7evaFGVPPhfIeVFSeL02F9 eUw40QnOflyInhy39KkJCIW81+mNUKhV5fwl5LtWmzDNawjrMMBTROT3DqI4Ho7A9hyJ 8rRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=bPSzWVIOz5/ECAvHbD2+qWropcS5v1a5C8wdu8b9VKo=; b=fXrputIOeH8SFcGrvrqJR7ZR3dxMlmkA/7A0GrU1qRjEreJ0WoXnef4DADf80v/BHx BhRBk8QyqrQc3rTCI+4tyHCK/NHTC2R8R0vZwR0I8wR/z88LEPx+NDQ8CS9sijc/5VMe uJyLl44NoZ41I8Eeu8om1wD4E5hIIfDsZzLIgbEB3Ne4zIWJ9imScIPn/I8U4Cbhmu7x tN98rbzUNOv37Sbs6sr8rn0CwvBb7HG6Q+W6hRky6rLiDmAYHrGwMFLZHDQb41SB5GYz ocvQ7qJ16FvlJIRtzGiTwhxswqnFgUUxbW/nE1gIsSzHdaUQOlfoB18t38Lfp+Rzu0a/ PEEw== X-Gm-Message-State: AKaTC00Noy3Mey7aEIF5SQYoX1n2D/y8aBuMok/dqVQfBkfzSy8neUmfqmIGRDTlPDqy7A== X-Received: by 10.36.233.66 with SMTP id f63mr4540874ith.55.1479609093580; Sat, 19 Nov 2016 18:31:33 -0800 (PST) Received: from zhabar.knownspace (50-80-150-234.client.mchsi.com. [50.80.150.234]) by smtp.gmail.com with ESMTPSA id k198sm3735523itb.18.2016.11.19.18.31.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Nov 2016 18:31:33 -0800 (PST) Sender: Justin Hibbits Date: Sat, 19 Nov 2016 20:31:28 -0600 From: Justin Hibbits To: Mark Millard Cc: svn-src-head@freebsd.org, FreeBSD Current , Alan Cox Subject: Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860] Message-ID: <20161119203128.2ac46708@zhabar.knownspace> In-Reply-To: <39962D4C-29BA-4AA4-B77D-2344A68FDB54@dsl-only.net> References: <39962D4C-29BA-4AA4-B77D-2344A68FDB54@dsl-only.net> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.29; powerpc64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2016 02:31:36 -0000 On Sat, 19 Nov 2016 18:19:37 -0800 Mark Millard wrote: > > Author: jhibbits > > Date: Fri Nov 18 22:59:33 2016 > > New Revision: 308817 > > URL: https://svnweb.freebsd.org/changeset/base/308817 > > > > Log: > > Fix buildworld > > > > Change the pv_tracked flag to an int, just in case userspace > > decides to include this file and defines BOOKE. > > > > Guard this block from unintentional inclusion with ifdef BOOKE. > > > > Reported by: emaste > . . . > > (Later quotes are not from the list or from E-mail but from files.) > > I'm not targeting BOOKE but GENERIC64 (via include, with AIM but not > ps3). I'm at head -r308860 yet for TARGET_ARCH=powerpc64 I get the > following that did not happen with my older -r308247 builds: > > > --- kinfo_getallproc.o --- > . . . > > In file included from /usr/src/sys/sys/user.h:53:0, > > from q:34: > > /usr/src/sys/vm/vm_map.h:190:2: error: unknown type name 'pmap_t' > > pmap_t pmap; /* (c) Physical map */ > > ^ > > /usr/src/sys/vm/vm_map.h:250:14: error: field 'vm_pmap' has > > incomplete type struct pmap vm_pmap; /* private physical map */ > > ^ > > --- kinfo_getfile.o --- > > In file included from /usr/src/sys/sys/user.h:53:0, > > from /usr/src/lib/libutil/kinfo_getfile.c:5: > > /usr/src/sys/vm/vm_map.h:190:2: error: unknown type name 'pmap_t' > > pmap_t pmap; /* (c) Physical map */ > > ^ > > /usr/src/sys/vm/vm_map.h:250:14: error: field 'vm_pmap' has > > incomplete type struct pmap vm_pmap; /* private physical map */ > > > It is almost like a machine/pmap.h include is missing now so that the > types are not defined. But I've not yet found where the relevant > difference(s) are from -r308247. > > Showing a compile command (with -v) with its failure. . . > The change is the "#elif defined(BOOKE)". Since userspace doesn't define either AIM nor BOOKE, struct pmap no longer exists. Alan, do you know if vmspace *needs* struct pmap to exist when read from userspace (in libprocstat and libkvm, from what I grepped)? If not, I can add a simple '#else struct pmap {};' to quiet the build. - Justin