From owner-dev-commits-src-all@freebsd.org Sat Apr 10 01:33:51 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F6715C6A43; Sat, 10 Apr 2021 01:33:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FHHb31Vztz4sRp; Sat, 10 Apr 2021 01:33:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 13A1Xbjc070960 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 10 Apr 2021 04:33:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 13A1Xbjc070960 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 13A1Xbgq070959; Sat, 10 Apr 2021 04:33:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 10 Apr 2021 04:33:37 +0300 From: Konstantin Belousov To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 06d8a116bd6b - main - libc: add _get_tp() private function Message-ID: References: <202104092047.139KlBo3071549@gitrepo.freebsd.org> <4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4BDA2D21-D5D0-4EC2-B6F7-B99260D046E0@freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4FHHb31Vztz4sRp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2021 01:33:51 -0000 On Fri, Apr 09, 2021 at 09:57:55PM +0100, Jessica Clarke wrote: > On 9 Apr 2021, at 21:47, Konstantin Belousov wrote: > > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac > > > > commit 06d8a116bd6b6f70b8aedc6a6a2c4085c53f63ac > > Author: Konstantin Belousov > > AuthorDate: 2021-04-05 03:30:35 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2021-04-09 20:46:24 +0000 > > > > libc: add _get_tp() private function > > > > which returns pointer to tcb > > This feels like it should be static inline in a header. Also we already have > _tcb_get in pthread_md.h that should be entirely equivalent, and > _libc_get_static_tls_base that’s basically the same again but with an optional > offset. Can we do something to unify all the inline asm into one place per > architecture rather than growing yet more copies of the same thing? Yes, this should happens, eventually.