From owner-svn-ports-head@freebsd.org Tue Mar 15 17:06:37 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1F15AD1969; Tue, 15 Mar 2016 17:06:37 +0000 (UTC) (envelope-from novel@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 843681A49; Tue, 15 Mar 2016 17:06:37 +0000 (UTC) (envelope-from novel@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u2FH6afj005786; Tue, 15 Mar 2016 17:06:36 GMT (envelope-from novel@FreeBSD.org) Received: (from novel@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u2FH6agr005785; Tue, 15 Mar 2016 17:06:36 GMT (envelope-from novel@FreeBSD.org) Message-Id: <201603151706.u2FH6agr005785@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: novel set sender to novel@FreeBSD.org using -f From: Roman Bogorodskiy Date: Tue, 15 Mar 2016 17:06:36 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r411194 - head/deskutils/spice-gtk X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2016 17:06:37 -0000 Author: novel Date: Tue Mar 15 17:06:36 2016 New Revision: 411194 URL: https://svnweb.freebsd.org/changeset/ports/411194 Log: deskutils/spice-gtk: fix BUILD_DEPENDS when GSTREAMER is off The deskutils/spice-gtk port adds 'python' to USES only when SPICE_SLAVE is defined. However, it unconditionally adds python dependencies to BUILD_DEPENDS and uses PYTHON_PKGNAMEPREFIX that's defined via USES=python, and that looks like a bug. However, when GSTREAMER option is enabled (that's the default), Mk/bsd.gstreamer.mk sets PYTHON_PKGNAMEPREFIX to 'py*-' if it's not defined, so the bug is not triggered with the default options set, but fails when GSTREAMER is disabled. Fix this by unconditionally adding 'python' to USES. Approved by: Oleg Ginzburg (maintainer, via email) Modified: head/deskutils/spice-gtk/Makefile Modified: head/deskutils/spice-gtk/Makefile ============================================================================== --- head/deskutils/spice-gtk/Makefile Tue Mar 15 17:01:33 2016 (r411193) +++ head/deskutils/spice-gtk/Makefile Tue Mar 15 17:06:36 2016 (r411194) @@ -13,7 +13,7 @@ LICENSE= GPLv2 USE_XORG= pixman USE_GNOME= gnomeprefix gtk20 gtk30 intltool introspection:build -USES= cpe gmake jpeg libtool pkgconfig tar:bzip2 pathfix +USES= cpe gmake jpeg libtool pkgconfig tar:bzip2 pathfix python CPE_VENDOR= redhat BUILD_DEPENDS= spice-protocol>=0.12.10:${PORTSDIR}/devel/spice-protocol \ @@ -27,7 +27,6 @@ BUILD_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}g RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}gtk2>=0:${PORTSDIR}/x11-toolkits/py-gtk2 CONFIGURE_ARGS+= --with-python PLIST_FILES+= %%PYTHON_SITELIBDIR%%/SpiceClientGtk.so -USES+= python .endif CONFIGURE_ENV+= SSL_CFLAGS=-I${OPENSSLINC} \