From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Sep 18 09:20:34 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B7BF16A4D0 for ; Sat, 18 Sep 2004 09:20:34 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F416C43D1F for ; Sat, 18 Sep 2004 09:20:33 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i8I9KXLo058947 for ; Sat, 18 Sep 2004 09:20:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8I9KXih058946; Sat, 18 Sep 2004 09:20:33 GMT (envelope-from gnats) Resent-Date: Sat, 18 Sep 2004 09:20:33 GMT Resent-Message-Id: <200409180920.i8I9KXih058946@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, RiÄardas Äepas Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 913F416A4CF for ; Sat, 18 Sep 2004 09:19:40 +0000 (GMT) Received: from richard.strangled.net (ctv-213-164-101-17.vinita.lt [213.164.101.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD25543D45 for ; Sat, 18 Sep 2004 09:19:39 +0000 (GMT) (envelope-from rch@richard.strangled.net) Received: from richard.strangled.net (localhost [127.0.0.1]) by richard.strangled.net (8.13.1/8.13.1) with ESMTP id i8I9JaBa002106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 18 Sep 2004 12:19:37 +0300 (EEST) (envelope-from rch@richard.strangled.net) Received: (from rch@localhost) by richard.strangled.net (8.13.1/8.13.1/Submit) id i8I9Jaig002105; Sat, 18 Sep 2004 12:19:36 +0300 (EEST) (envelope-from rch) Message-Id: <200409180919.i8I9Jaig002105@richard.strangled.net> Date: Sat, 18 Sep 2004 12:19:36 +0300 (EEST) From: RiÄardas Äepas To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/71856: net/kphone startup problem with multiple interfaces (patch) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: RiÄardas Äepas List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Sep 2004 09:20:34 -0000 >Number: 71856 >Category: ports >Synopsis: net/kphone startup problem with multiple interfaces (patch) >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Sep 18 09:20:33 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Richard Cepas >Release: FreeBSD 5.3-BETA2 i386 >Organization: >Environment: System: FreeBSD richard.strangled.net 5.3-BETA2 FreeBSD 5.3-BETA2 #3: Sun Sep 5 14:30:41 EEST 2004 rch@richard.strangled.net:/usr/local/obj/usr/src/sys/MYKERNEL i386 >Description: Doesn't start in case there are 2 network cards attached. I think getdefaultdev() in dissipate2/siputil.cpp is Linux specific and always returns NULL. The workaround below lets kphone to start even if NULL is received from getdefaultdev(). >How-To-Repeat: Start kphone on box with two NICs. >Fix: --- kphone/dissipate2/siputil.cpp.orig2 Mon Sep 13 17:30:46 2004 +++ kphone/dissipate2/siputil.cpp Mon Sep 13 17:44:52 2004 @@ -164,9 +164,9 @@ dissipate_our_fqdn = strdup( if_addr[0] ); } else { default_ifName = getdefaultdev(); - if( default_ifName != NULL) { + /*if( default_ifName != NULL) {*/ for( i = 0; i < j; i++ ) { - if( strcmp( if_name[i], default_ifName ) == 0 ) { + if( default_ifName != NULL && strcmp( if_name[i], default_ifName ) == 0 ) { QMessageBox mb( "KPhone", "KPhone found more than one interface.\n" "Do you want to use the default interface:\n\n" + @@ -187,7 +187,7 @@ } } for( i = 0; i < j; i++ ) { - if( strcmp( if_name[i], default_ifName ) != 0 ) { + if(default_ifName == NULL || strcmp( if_name[i], default_ifName ) != 0 ) { if( i == j-1 ) { QMessageBox mb( "KPhone", "Do you want to use " + QString(if_name[i]) + " (IP:\"" + QString(if_addr[i]) + "\")", @@ -221,7 +221,7 @@ } } } - } + /*}*/ } } >Release-Note: >Audit-Trail: >Unformatted: