From owner-svn-src-head@FreeBSD.ORG Sun Sep 22 03:46:34 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F233FE12; Sun, 22 Sep 2013 03:46:33 +0000 (UTC) (envelope-from gibbs@FreeBSD.org) Received: from aslan.scsiguy.com (aslan.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B9067280C; Sun, 22 Sep 2013 03:46:33 +0000 (UTC) Received: from macbook.scsiguy.com (macbook.scsiguy.com [192.168.0.99]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r8M3kVLb069597 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sat, 21 Sep 2013 21:46:32 -0600 (MDT) (envelope-from gibbs@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: svn commit: r255783 - head/sys/kern From: "Justin T. Gibbs" In-Reply-To: <523E6538.5090301@freebsd.org> Date: Sat, 21 Sep 2013 21:46:30 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <0CCA0163-C649-4A61-B6E6-06096327461E@FreeBSD.org> References: <201309220246.r8M2kEIN054172@svn.freebsd.org> <523E6538.5090301@freebsd.org> To: Nathan Whitehorn X-Mailer: Apple Mail (2.1510) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [192.168.0.4]); Sat, 21 Sep 2013 21:46:32 -0600 (MDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Sep 2013 03:46:34 -0000 On Sep 21, 2013, at 9:34 PM, Nathan Whitehorn = wrote: > On 09/21/13 21:46, Justin T. Gibbs wrote: >> Author: gibbs >> Date: Sun Sep 22 02:46:13 2013 >> New Revision: 255783 >> URL: http://svnweb.freebsd.org/changeset/base/255783 >>=20 >> Log: >> Fix ia64 and mips kernel builds due to XENHVM=3D>GENERIC = integration in >> revision 255744. >> sys/kern/subr_smp.c: >> IPI_SUSPEND is only available on amd64 and i386. Protect >> new uses of this constant with #ifdefs to avoid impacting >> other platforms. >=20 > Would it make more sense just to add this to other platforms? It = needn't actually be sent, of course, and it would cut down on = platform-specific #ifdef in MI code, which is universally a good thing. > -Nathan Sure. But the build was broken and I opted to restore the status quo = rather than take the more time consuming path of trying to clean up all = of the other #ifdefs and then having to reverify builds on all supported = platforms. -- Justin=