From owner-freebsd-arm@FreeBSD.ORG  Thu Nov  8 13:19:50 2007
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1637C16A41A
	for <freebsd-arm@freebsd.org>; Thu,  8 Nov 2007 13:19:50 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (dong.ci0.org [IPv6:2001:7a8:2066:1::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 2FAC213C494
	for <freebsd-arm@freebsd.org>; Thu,  8 Nov 2007 13:19:48 +0000 (UTC)
	(envelope-from mlfbsd@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.13.8/8.13.8) with ESMTP id lA8EDgX4035407;
	Thu, 8 Nov 2007 15:13:42 +0100 (CET)
	(envelope-from mlfbsd@dong.ci0.org)
Received: (from mlfbsd@localhost)
	by dong.ci0.org (8.14.1/8.13.8/Submit) id lA8EDgYr035406;
	Thu, 8 Nov 2007 15:13:42 +0100 (CET) (envelope-from mlfbsd)
Date: Thu, 8 Nov 2007 15:13:41 +0100
From: Olivier Houchard <mlfbsd@ci0.org>
To: Rafal Jaworowski <raj@semihalf.com>
Message-ID: <20071108141341.GA35343@ci0.org>
References: <47330BC3.3050208@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47330BC3.3050208@semihalf.com>
User-Agent: Mutt/1.4.1i
Cc: freebsd-arm@freebsd.org
Subject: Re: ARM9E missing l2cache_* entries
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2007 13:19:50 -0000

On Thu, Nov 08, 2007 at 02:14:43PM +0100, Rafal Jaworowski wrote:
> Hi,
> 
> It seems there are missing entries for the l2cache_* calls in current
> armv5_ec_cpufuncs initialization:
> 
> --- a/src/sys/arm/arm/cpufunc.c
> +++ b/src/sys/arm/arm/cpufunc.c
> @@ -332,6 +332,10 @@ struct cpu_functions armv5_ec_cpufuncs =
> 
>         armv5_ec_idcache_wbinv_all,     /* idcache_wbinv_all    */
>         armv5_ec_idcache_wbinv_range,   /* idcache_wbinv_range  */
> +       cpufunc_nullop,                 /* l2cache_wbinv_all    */
> +       (void *)cpufunc_nullop,         /* l2cache_wbinv_range  */
> +       (void *)cpufunc_nullop,         /* l2cache_inv_range    */
> +       (void *)cpufunc_nullop,         /* l2cache_wb_range     */
> 
>         /* Other functions */
> 
> 

I committed it. Thanks !

> BTW: is really both CPU_ARM9 and CPU_ARM9E needed like we have in the
> sys/arm/at91/std.at91? I'm a bit confused when looking at the cpufunc.c if
> they are meant mutually exclusive or not?
> 
> Rafal

I'd guess yes. CPU_ARM9 is armv4, CPU_ARM9E is armv5.

Regards,

Olivier