From owner-dev-commits-src-all@freebsd.org Fri May 21 18:50:59 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 93A266398C0; Fri, 21 May 2021 18:50:59 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fmwfq3JGxz3pjR; Fri, 21 May 2021 18:50:59 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82a.google.com with SMTP id m13so15998826qtk.13; Fri, 21 May 2021 11:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TOGmC3E9/OdBAAd6wXGZ/sTfMHJGtfGsSiuBncBhl9g=; b=e4K5Hxm/JwOunU6QioxjCV2Owm2bCs/aapPMpXOUjxSev+hBrMDYRldkiNuKg4UcfD iyvw9aq7TLgf3DI4VZ0otbq0PIWH6FzHjIxey6B6Xrl2A09Jz4QfgVR0YfvplOKbk4wF g9VelyLPf4VAcYhIBWyQFJ4fD47l/YGi3EAc2qjqdUbiy5nEFtHlcvLevtgiNjPxUwVv IgSzxGm7JIDtmJRFHXymuGxD5lgdyGsJVBCJDQOtaAVRfqN86gVlpPlYadufWXPcJm/2 Qeuhsnw6rrWSYmOj8PLErM6GFwc3xygqdkQ1W5b97l7Mxqhk8VIsswLEJVNV7NM6RlNq GI5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=TOGmC3E9/OdBAAd6wXGZ/sTfMHJGtfGsSiuBncBhl9g=; b=fTzVMj6GlICVnl48U4DFWX7AJ0jumesgTJ/TcCgkndQf9xQI2fJD11o2neDww6x8uu o5qtMHeS8/q4ji+Llcxtq1B+mug1DUqIhgNwq9lKtTy2l+bQGDpHyey/r4J+6M5h/ruM t6gvFGDA/NtAn1WV8nzJp4kTpJN+snT8X1cdWrxIykHKA4DaUx7/BLSfTHAYiruOCRcs a//FArKJcgNAxGrKuca/CxRrxLhKgG20ZtB2tPb+t/jBDKJfQ5ZCBOfPK3a//kC2CySe +hidqPjDJmxDLNAT6xEUxnQ9yATCtT8+xd8p1G/44UXRE7cPo99jD4gsGihPQkWKOUoh hVcQ== X-Gm-Message-State: AOAM531A/zIh83a0EAhRfLpZMJqePR/BafQyiOvGcD5pA2j8cQgz38RD RMSIhX+WnGxaFMw8HexDq7zCN3YnWn8Tnw== X-Google-Smtp-Source: ABdhPJxS6f3vs16PHmGgQ74C2VY1YJ4k5AAx9sUJwOfoM/m48Mx49G/Um01Fn+PqGb5rAY5rYkugvw== X-Received: by 2002:a05:622a:202:: with SMTP id b2mr12583644qtx.343.1621623058335; Fri, 21 May 2021 11:50:58 -0700 (PDT) Received: from nuc ([142.126.172.178]) by smtp.gmail.com with ESMTPSA id c9sm5885463qke.8.2021.05.21.11.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 11:50:57 -0700 (PDT) Sender: Mark Johnston Date: Fri, 21 May 2021 14:50:57 -0400 From: Mark Johnston To: Richard Scheffenegger Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 032bf749fd44 - main - [tcp] Keep socket buffer locked until upcall Message-ID: References: <202105210908.14L98fTa045092@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202105210908.14L98fTa045092@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4Fmwfq3JGxz3pjR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 18:50:59 -0000 On Fri, May 21, 2021 at 09:08:41AM +0000, Richard Scheffenegger wrote: > The branch main has been updated by rscheff: > > URL: https://cgit.FreeBSD.org/src/commit/?id=032bf749fd44ac5ff20aab2c3d8e3c05491778ea > > commit 032bf749fd44ac5ff20aab2c3d8e3c05491778ea > Author: Richard Scheffenegger > AuthorDate: 2021-05-21 09:00:53 +0000 > Commit: Richard Scheffenegger > CommitDate: 2021-05-21 09:07:51 +0000 > > [tcp] Keep socket buffer locked until upcall > > r367492 would unlock the socket buffer before eventually calling the upcall. > This leads to problematic interaction with NFS kernel server/client components > (MP threads) accessing the socket buffer with potentially not correctly updated > state. The RACK change at least appears to have introduced a bug: https://syzkaller.appspot.com/bug?id=d7abacdaf60c556dbfa05f15f460cd7174e974ba https://syzkaller.appspot.com/bug?id=650a391473e34b753b280db1c9c97918d23c6cdb