Date: Wed, 17 Nov 2004 11:24:48 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: scottl@FreeBSD.org Subject: Re: New ACPI PCI Link Routing code Message-ID: <200411171124.48268.jhb@FreeBSD.org> In-Reply-To: <20041117154146.GD25995@ip.net.ua> References: <200411111737.00537.jhb@FreeBSD.org> <200411161339.13818.jhb@FreeBSD.org> <20041117154146.GD25995@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 17 November 2004 10:41 am, Ruslan Ermilov wrote: > On Tue, Nov 16, 2004 at 01:39:13PM -0500, John Baldwin wrote: > > On Thursday 11 November 2004 05:37 pm, John Baldwin wrote: > > > I've done some work on the ACPI PCI link code to make it a bit more > > > like $PIR in that it is link centric and uses actual new-bus devices > > > for each device link. One benefit of this is that unused links will be > > > disabled now which might help with interrupt aliasing problems on > > > machines using APICs. Also, instead of routing IRQs for links via PCI > > > device numbers using tunables, they are now routed via the link name > > > ala $PIR. Thus, one uses 'hw.pci.link.LNKA.irq=X' to route LNKA to IRQ > > > X. Also, when choosing a virgin interrupt, we no longer try to guess > > > at which IRQs might be used by ISA devices. Instead, we only use > > > known-good IRQs including IRQs that the BIOS has already used and the > > > SCI if the link is being routed via ISA IRQs. The patch is at > > > http://www.FreeBSD.org/~jhb/patches/acpi_pci_link.patch Please test and > > > let me know if there are any problems, thanks. > > > > I've updated this to the latest current and verified that it compiles ok > > (since I had at least one report that it didn't patch cleanly and/or > > compile). I plan to commit this in a couple of days unless I hear some > > sort of negative feedback. > > I get a panic on boot with this change. I don't have a serial > console attached to this notebook, but if needs be it can be > arranged (tomorrow). The panic I get is as follows: > > panic: Assertion resource->Data.Irq.NumberOfInterrupts == 1 failed at > .../acpi_pci_link.c:497 Can you print out what 'NumberOfInterrupts' is before the printf? Drew has a machine that has hit the same panic as well. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411171124.48268.jhb>