From owner-cvs-all@FreeBSD.ORG Wed Apr 21 03:35:59 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5560A16A4CE; Wed, 21 Apr 2004 03:35:59 -0700 (PDT) Received: from www.russia.cz (web.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E6EB43D1F; Wed, 21 Apr 2004 03:35:58 -0700 (PDT) (envelope-from sobomax@portaone.com) Received: from portaone.com (localhost [127.0.0.1]) (authenticated bits=0) by www.russia.cz (8.12.8p2/8.12.8) with ESMTP id i3LAZqb1092897; Wed, 21 Apr 2004 12:35:53 +0200 (CEST) (envelope-from sobomax@portaone.com) Message-ID: <40864E82.90904@portaone.com> Date: Wed, 21 Apr 2004 13:35:46 +0300 From: Maxim Sobolev User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 (ax) X-Accept-Language: en-us, en, ru, uk MIME-Version: 1.0 To: Eivind Eklund References: <200404181922.i3IJMkTf044706@repoman.freebsd.org> <20040419032304.GA61048@regency.nsu.ru> <20040419103101.GB26102@dragon.nuxi.com> <20040419110810.GA24385@regency.nsu.ru> <20040420200903.GA6174@dragon.nuxi.com> <20040421094050.GA5052@FreeBSD.org> In-Reply-To: <20040421094050.GA5052@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Alexey Dokuchaev cc: Clement Laforet cc: cvs-all@FreeBSD.ORG cc: ports-committers@FreeBSD.ORG cc: David O'Brien cc: cvs-ports@FreeBSD.ORG Subject: Re: files/patch-* pathname separators (was Re: cvs commit:ports/games Makefile ...) X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2004 10:35:59 -0000 I disagree. `::' is pretty harmless, I never had any problems due to it. And, yes, I use bash as my primary shell. -Maxim Eivind Eklund wrote: > On Tue, Apr 20, 2004 at 01:09:03PM -0700, David O'Brien wrote: > >>On Mon, Apr 19, 2004 at 06:08:10PM +0700, Alexey Dokuchaev wrote: >> >>>While particular choice for a separator is arguable, the general scheme >>>for patch-files is not, right? FWIW, that was my point, not `::' vs. >>>whatever. >>> >>>As a side note, I don't really see any problem with `::' or `-'. >> >>1. Bash escapes it so it actually becomes 4 characters. >> This should not be takeing lightly -- people bitched about '%' in >> patch names and they were all changed because its a magic charter for >> Perforce and Perforce users could be bothered to escape it. >> >>2. With the file name lenths of some of our patches (greater than 80 >> chars) two characters, when one will do, is annoying. > > > If nobody objects, I'll add the following patch to the porters handbook > to avoid profileration. > > Index: book.sgml > =================================================================== > RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/porters-handbook/book.sgml,v > retrieving revision 1.400 > diff -u -r1.400 book.sgml > --- book.sgml 16 Apr 2004 15:05:32 -0000 1.400 > +++ book.sgml 21 Apr 2004 09:38:25 -0000 > @@ -617,7 +617,10 @@ > first, ab second and so on. If you wish, > you can use names that indicate the pathnames of the files that > are patched, such as patch-Imakefile or > - patch-src-config.h. These files should > + patch-src-config.h. Due to issues with > + escaping in bash and Perforce, > + you should avoid using :: or % as separator in the patch filename. > + The files should > be stored in PATCHDIR, from where they will be > automatically applied. All patches should be relative to > WRKSRC (generally the directory your port's > > Eivind. > > >