Date: Sat, 11 Feb 2012 18:13:11 +0000 (UTC) From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/sysutils/k3b-kde4 Makefile ports/sysutils/k3b-kde4/files patch-libk3bdevice-k3bscsicommandbsd.cpp Message-ID: <201202111813.q1BIDBQr059672@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rakuco 2012-02-11 18:13:11 UTC
FreeBSD ports repository
Modified files:
sysutils/k3b-kde4 Makefile
sysutils/k3b-kde4/files
patch-libk3bdevice-k3bscsicommandbsd.cpp
Log:
k3b-kde4: Update the libk3bdevice/k3bscsicommandbsd.cpp patch.
I committed a6a2ed3 to k3b's git tree some time ago. It is a patch by
avg@ improving the file and preventing some bugs from occurring. In
his own words in KDE git review request 103293:
Main idea of the change is to improve the case where SCSI sense data
is not automatically provided and has to be explicitly requested.
Current code essentially duplicates main transport code for this
task. The proposed code recursively calls into the transport code
with MMC_REQUEST_SENSE command. This also fixes a problem with the
existing code where it re-uses a CCB of the original command for sense
fetching but doesn't ensure that all the previously used bytes are
reset to proper values. This can result in a malformed
MMC_REQUEST_SENSE CCB which can confuse certain hardware (e.g. it
hangs Optiarc DVD RW AD-7191S 1.02). Also the style of the code is
cleaned up. Because of the code re-use the code is now more compact.
Additionally some historic and useless code was dropped - the code for
setting errno. errno value is not used by the calling code and this
is an artifact of the FreeBSD-specific code having been borrowed from
a different project (as attested by Heiner Eichmann
<h.eichmann@gmx.de>).
The current patch in the port now contains both commits 4ffc589 and
a6a2ed3 squashed together.
Bump PORTREVISION accordingly.
Submitted by: avg
Revision Changes Path
1.79 +1 -1 ports/sysutils/k3b-kde4/Makefile
1.2 +251 -62 ports/sysutils/k3b-kde4/files/patch-libk3bdevice-k3bscsicommandbsd.cpp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201202111813.q1BIDBQr059672>