Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 May 2024 20:40:39 +0200
From:      Daniel Engberg <daniel.engberg.lists@pyret.net>
To:        Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 0df6c8368918 - main - devel/libcjson: Update to 1.7.18
Message-ID:  <200ac8a8adacc847fe905442377749eb@mail.infomaniak.com>
In-Reply-To: <202405191723.44JHNkPw058983@gitrepo.freebsd.org>
References:  <202405191723.44JHNkPw058983@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-05-19T19:23:46.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrot=
e:
>  The branch main has been updated by sunpoet:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D0df6c8368918d6d1905b141e=
93cf0c55cf9803f8
>=20
> commit 0df6c8368918d6d1905b141e93cf0c55cf9803f8
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> AuthorDate: 2024-05-19 16:15:08 +0000
> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> CommitDate: 2024-05-19 17:15:06 +0000
>=20
>     devel/libcjson: Update to 1.7.18
>    =20
>     - Use USES=3Dpathfix to fix .pc installation
>    =20
>     Changes:        https://github.com/DaveGamble/cJSON/releases
>     Security:       CVE-2024-31755
> ---
>  devel/libcjson/Makefile | 6 +++---
>  devel/libcjson/distinfo | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/devel/libcjson/Makefile b/devel/libcjson/Makefile
> index 5a0e276ca30d..2f5f4624cb1b 100644
> --- a/devel/libcjson/Makefile
> +++ b/devel/libcjson/Makefile
> @@ -1,5 +1,5 @@
>  PORTNAME=3D=09libcjson
> -PORTVERSION=3D=091.7.17
> +PORTVERSION=3D=091.7.18
>  DISTVERSIONPREFIX=3D=09v
>  CATEGORIES=3D=09devel
> =20
> @@ -10,10 +10,10 @@ WWW=3D=09=09https://github.com/DaveGamble/cJSON
>  LICENSE=3D=09MIT
>  LICENSE_FILE=3D=09${WRKSRC}/LICENSE
> =20
> -USES=3D=09=09cmake:testing compiler:c11
> +USES=3D=09=09cmake:testing compiler:c11 pathfix
> =20
>  CMAKE_OFF=3D=09CJSON_OVERRIDE_BUILD_SHARED_LIBS ENABLE_CJSON_TEST ENABLE=
_CUSTOM_COMPILER_FLAGS ENABLE_HIDDEN_SYMBOLS ENABLE_SAFE_STACK ENABLE_SANIT=
IZERS
> -CMAKE_ON=3D=09BUILD_SHARED_AND_STATIC_LIBS BUILD_SHARED_LIBS CJSON_BUILD=
_SHARED_LIBS ENABLE_CJSON_UTILS ENABLE_LOCALES ENABLE_PUBLIC_SYMBOLS ENABLE=
_TARGET_EXPORT
> +CMAKE_ON=3D=09BUILD_SHARED_AND_STATIC_LIBS BUILD_SHARED_LIBS CJSON_BUILD=
_SHARED_LIBS ENABLE_CJSON_UNINSTALL ENABLE_CJSON_UTILS ENABLE_CJSON_VERSION=
_SO ENABLE_LOCALES ENABLE_PUBLIC_SYMBOLS ENABLE_TARGET_EXPORT
>  CMAKE_TESTING_ON=3D=09ENABLE_CJSON_TEST ENABLE_SAFE_STACK
>  USE_CSTD=3D=09c11
> =20
> diff --git a/devel/libcjson/distinfo b/devel/libcjson/distinfo
> index 27dc7e7d7dd1..0842dd750e7a 100644
> --- a/devel/libcjson/distinfo
> +++ b/devel/libcjson/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP =3D 1708448902
> -SHA256 (DaveGamble-cJSON-v1.7.17_GH0.tar.gz) =3D c91d1eeb7175c50d49f6ba2=
a25e69b46bd05cffb798382c19bfb202e467ec51c
> -SIZE (DaveGamble-cJSON-v1.7.17_GH0.tar.gz) =3D 353748
> +TIMESTAMP =3D 1715842516
> +SHA256 (DaveGamble-cJSON-v1.7.18_GH0.tar.gz) =3D 3aa806844a03442c00769b8=
3e99970be70fbef03735ff898f4811dd03b9f5ee5
+SIZE (DaveGamble-cJSON-v1.7.18_GH0.tar.gz) =3D 354726

Hi,

Any specific reason as to why we're hardcoding c11 when upstream targets c8=
9?
https://github.com/DaveGamble/cJSON/blob/v1.7.18/CMakeLists.txt#L22
See also https://github.com/DaveGamble/cJSON/pull/836

Best regards,
Daniel



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200ac8a8adacc847fe905442377749eb>