From owner-freebsd-commit Sat Mar 25 20:05:10 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA26890 for commit-outgoing; Sat, 25 Mar 1995 20:05:10 -0800 Received: from isl.cf.ac.uk (isl-gate.elsy.cf.ac.uk [131.251.22.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id UAA26882 for ; Sat, 25 Mar 1995 20:05:03 -0800 Received: (from paul@localhost) by isl.cf.ac.uk (8.6.9/8.6.9) id EAA01865; Sun, 26 Mar 1995 04:05:39 GMT From: Paul Richards Message-Id: <199503260405.EAA01865@isl.cf.ac.uk> Subject: Re: cvs commit: src/sys/i386/conf Makefile.i386 To: asami@cs.berkeley.edu (Satoshi Asami/=?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Date: Sun, 26 Mar 1995 04:05:38 +0000 (GMT) Cc: commit@FreeBSD.ORG In-Reply-To: <199503260355.TAA00898@silvia.HIP.Berkeley.EDU> from "Satoshi Asami/=?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=" at Mar 25, 95 07:55:53 pm X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1775 Sender: commit-owner@FreeBSD.ORG Precedence: bulk In reply to Satoshi Asami/=?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?= who said > > * If I was complaining about anything you'd done specifically I'd > * have replied to you only, rather than to the list and there's been > * no reason to do that so I haven't :-) > > Not that I thought you were complaining to me, but you did send the > mail to me only.... Oops, did I? Mistake on my part. Sorry. I'm forwarding this to the commit list. > > * No you can't automate the deletion of those lines since it depends on > * where the committed code is coming from, therefore it's up to the > * committer to delete the lines that don't apply. > > I don't understand why it is so. If it can delete the "CVS:" lines > (or whatever), can't we just add "Submitted by:" to the list of lines > to delete? We just need to make sure there isn't any non-space thing > after the colons. > > How do we delete the "CVS:" lines? A sed script? There's no way for cvs to know where the commit you made came from so there's no way to automate this. The committer has to delete those lines themselves. The CVS: lines do not appear in the commit logs. The three lines that we're talking about are not CVS: lines. If you stick CVS: in front of those lines then it'll be up to the committer to add them rather than delete them which is even worse since it's politicaly more important to include them when the fix has been taken from other os's such as NetBSD. That's why we added extra cases in the first place. -- Paul Richards, FreeBSD core team member. Internet: paul@FreeBSD.org, URL: http://isl.cf.ac.uk/~paul/ Phone: +44 1222 874000 x6646 (work), +44 1222 457651 (home) Dept. Mechanical Engineering, University of Wales, College Cardiff.