From owner-svn-src-head@freebsd.org  Sat Apr 22 20:06:43 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45A8CD4A01B;
 Sat, 22 Apr 2017 20:06:43 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1F0189AB;
 Sat, 22 Apr 2017 20:06:43 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v3MK6foK047693;
 Sat, 22 Apr 2017 13:06:42 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v3MK6fYX047692;
 Sat, 22 Apr 2017 13:06:41 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201704222006.v3MK6fYX047692@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r317290 - head/tools/regression/geom_gpt
In-Reply-To: <201704222000.v3MK0qM2060655@repo.freebsd.org>
To: Ngie Cooper <ngie@freebsd.org>
Date: Sat, 22 Apr 2017 13:06:41 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Apr 2017 20:06:43 -0000

> Author: ngie
> Date: Sat Apr 22 20:00:52 2017
> New Revision: 317290
> URL: https://svnweb.freebsd.org/changeset/base/317290
> 
> Log:
>   Fix -Wimplicit-function-declaration compilation warning by moving libgeom.h
>   #include below the stdio.h #include.
>   
>   gctl_dump(3) needs stdio.h, per reasoning noted in r317289.
>   
>   MFC after:	5 weeks
>   PR:		218809
>   Submitted by:	Chang-Hsien Tsai <luke.tw@gmail.com>
>   Sponsored by:	Dell EMC Isilon
> 
> Modified:
>   head/tools/regression/geom_gpt/test.c
> 
> Modified: head/tools/regression/geom_gpt/test.c
> ==============================================================================
> --- head/tools/regression/geom_gpt/test.c	Sat Apr 22 19:32:23 2017	(r317289)
> +++ head/tools/regression/geom_gpt/test.c	Sat Apr 22 20:00:52 2017	(r317290)
> @@ -29,12 +29,12 @@ __FBSDID("$FreeBSD$");
>  
>  #include <sys/param.h>
>  #include <errno.h>
> -#include <libgeom.h>
>  #include <limits.h>
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
>  #include <unistd.h>
> +#include <libgeom.h>
#include <libgeom.h>	/* This is not in alphabetic order per r317289 */
>  
>  struct retval {
>  	struct retval *retval;

Might it be a good idea to mark this in the test.c file as to why
these are not sorted in order to prevent regressions of this in
the future?


-- 
Rod Grimes                                                 rgrimes@freebsd.org