From owner-freebsd-current@FreeBSD.ORG Mon Mar 9 19:25:38 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C62D106566B for ; Mon, 9 Mar 2009 19:25:38 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 97E628FC13 for ; Mon, 9 Mar 2009 19:25:37 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 26A371CC94; Mon, 9 Mar 2009 20:25:36 +0100 (CET) Date: Mon, 9 Mar 2009 20:25:36 +0100 From: Ed Schouten To: pluknet Message-ID: <20090309192536.GY19161@hoeg.nl> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GjdfNfZESPgSEIx8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Cc: FreeBSD Current Subject: Re: panic: mutex Giant not owned at /usr/src/sys/kern/tty_ttydisc.c:1127 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2009 19:25:38 -0000 --GjdfNfZESPgSEIx8 Content-Type: multipart/mixed; boundary="SRdXq8ahTMo0Vx5K" Content-Disposition: inline --SRdXq8ahTMo0Vx5K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Can you try the attached patch? Let me know if it fixes the issue you're having. The reason why we're seeing such panics lately, is because the new TTY layer has one big improvement: it has assertions. This means that there are a lot of bugs in the old code where we call into the TTY layer without holding locks. Ugh. :-) --=20 Ed Schouten WWW: http://80386.nl/ --SRdXq8ahTMo0Vx5K Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="pluknet.diff" Index: syscons.c =================================================================== --- syscons.c (revision 189489) +++ syscons.c (working copy) @@ -3277,7 +3277,7 @@ sc_draw_cursor_image(scp); } tp = SC_DEV(sc, scp->index); - if (tty_opened(tp)) + if (!kdb_active && tty_opened(tp)) sctty_outwakeup(tp); #endif } --SRdXq8ahTMo0Vx5K-- --GjdfNfZESPgSEIx8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkm1bTAACgkQ52SDGA2eCwXWOQCfT3wG6jVPMaZFbcanbdJx3CTz cyAAnRMuH0a1QvnwM57N+Vu8Ad9vUn8w =smyp -----END PGP SIGNATURE----- --GjdfNfZESPgSEIx8--