From owner-svn-src-head@freebsd.org Wed Jun 6 18:26:29 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9321FDD76A; Wed, 6 Jun 2018 18:26:28 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76D14808F9; Wed, 6 Jun 2018 18:26:28 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by mail-io0-x22e.google.com with SMTP id g7-v6so8728277ioh.11; Wed, 06 Jun 2018 11:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OTBMT/ooCYELZ/1XVABfAehR0N51ftQfYRgM5U8KDyk=; b=uzUjAEjHdy1l96y6hQvvzCqJrpzULrhweituvsKUlsZYINxmXEVAueKhILs4saKSpT TtyxMXuWd+ZDhojKwl2sxkRJoCIon8I3aRLO+gG7EeHIItflAvQTv7cdxMWbro3lGSRc cRXbr+Vy+pPIizdSAOScRwM2Jye9nF0flAP+YBuzOJoG7XfLXFCpIxfOmJOoq6crZ/x4 OHt3HIZMyZuMehGjfU5UKp9CPqFN9JxnGfCsGSgVUimgvhRmF6Zy1tzLwFyHofHrBY5M 3XoR5MP49S3MIh3QAhCGAY4Mz10A7elhpb6Ouh5pphUG8s6YJHV/tDGTr5488jsWJ7na 0/uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OTBMT/ooCYELZ/1XVABfAehR0N51ftQfYRgM5U8KDyk=; b=V7kfVadMk3P359Z7wbNoysRs1fCm9n9DvPWXPGMPS6EtOrC8PknEgWUQk4jHa0z1sW eY/zlhiUQegsxhxL3zDqDPhh2vfHIW9EKVqrd3Q849Xu2+G30ZMBsPdKR6rISFKy5Wwi 7wkdVb+08by7YFoCXquHqOUOqg8tZJryE9H/8aiQPX6MwEmnJGZTIOAf8wZhR8ixTnYN WtuEnL30w0alZP1RN2xaADyDCFtv7uHTZI/G4UWNreFLaIAcTBNBYbEA3mMKsQWaPd47 HRdHjtAId+m/JFyErzmB8htJ8mj3CDS3n2cq/cp4upewusTlYcoddtLDoygpYHuvlmsb XjWA== X-Gm-Message-State: APt69E31Da47RYu/4H8O5av5j/31bAO9DNbMxbMHXTqvvplXOpAHVpEp olPsIAtWMh5+WCXLq0iSij3JEHmI/23GxKKH6I8= X-Google-Smtp-Source: ADUXVKK0rCjEOzAfice9pFTsxEiNzZMsQBJi3JQSEPZ7yfUPU8C29dXlvfXJupNHTPLGnAH/vRrxYDrI+bz3xksvOgc= X-Received: by 2002:a6b:582:: with SMTP id 124-v6mr3837799iof.94.1528309587493; Wed, 06 Jun 2018 11:26:27 -0700 (PDT) MIME-Version: 1.0 References: <201805252146.w4PLk7vL009258@repo.freebsd.org> <06289a72-2948-083f-d208-d9f36d88699e@FreeBSD.org> In-Reply-To: <06289a72-2948-083f-d208-d9f36d88699e@FreeBSD.org> From: Matthew Macy Date: Wed, 6 Jun 2018 11:26:16 -0700 Message-ID: Subject: Re: svn commit: r334226 - head/lib/libpmcstat/pmu-events To: Bryan Drewery Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 18:26:29 -0000 pmu events hasn't been in libpmcstat for a while On Wed, Jun 6, 2018 at 08:36 Bryan Drewery wrote: > On 6/5/18 12:32 AM, Kyle Evans wrote: > > On Mon, Jun 4, 2018 at 10:11 PM, Kyle Evans wrote: > >> On Fri, May 25, 2018 at 4:46 PM, Bryan Drewery > wrote: > >>> Author: bdrewery > >>> Date: Fri May 25 21:46:07 2018 > >>> New Revision: 334226 > >>> URL: https://svnweb.freebsd.org/changeset/base/334226 > >>> > >>> Log: > >>> Cleanup style > >>> > >>> Modified: > >>> head/lib/libpmcstat/pmu-events/Makefile > >>> > >>> Modified: head/lib/libpmcstat/pmu-events/Makefile > >>> > ============================================================================== > >>> --- head/lib/libpmcstat/pmu-events/Makefile Fri May 25 20:42:28 > 2018 (r334225) > >>> +++ head/lib/libpmcstat/pmu-events/Makefile Fri May 25 21:46:07 > 2018 (r334226) > >>> @@ -1,9 +1,10 @@ > >>> # $FreeBSD$ > >>> > >>> -PROG=jevents > >>> -SRCS=jevents.c jsmn.c json.c > >>> +PROG= jevents > >>> +SRCS= jevents.c jsmn.c json.c > >>> CFLAGS+= -Wno-cast-qual > >>> -.PATH: ${.CURDIR} > >>> -build-tools: jevents > >>> MAN= > >>> + > >>> +build-tools: jevents > >>> + > >>> .include > >>> > >> > >> Hi Bryan, > >> > >> Something about this appears to be subtly wrong, but I can't quite pin > >> down what. I'm getting a failure in the lib32 build of libpmc: > >> > >> sh: ./pmu-events/jevents: not found > > I believe this was fixed by r334455. > > >> > >> My observations are that ${OBJDIR}/lib/libpmc/pmu-events/jevents > >> exists, as does ${SRCTOP}/lib/libpmc/pmu-events/jevents. > >> ${OBJDIR}/obj-lib32/lib/libpmc, OTOH, only contains _INCSINS.meta and > >> libpmc_events.c.meta. I'm guessing this is the problem- that > >> obj-lib32/... doesn't have the built jevents, but it's not obvious to > >> me why this is the case. > > > > Some additional context: > > > > SRCCONF is defined to a file that looks like this: > > > > WITH_BSD_GREP="YES" > > WITHOUT_BSD_GREP_FASTMATCH="YES" > > WITH_LOADER_LUA="YES" > > WITHOUT_FORTH="YES" > > > > _SRC_ENV_CONF and __MAKE_CONF are set to /dev/null; all three set in > > arguments to make(1). OBJDIR has been completely wiped before-hand. > > > > > -- > Regards, > Bryan Drewery > >