From owner-svn-src-head@freebsd.org Thu Jan 14 10:25:27 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85D66A81F58; Thu, 14 Jan 2016 10:25:27 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249]) by mx1.freebsd.org (Postfix) with ESMTP id 5661A15F0; Thu, 14 Jan 2016 10:25:27 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from zapp (bcdd4360.skybroadband.com [188.221.67.96]) by kif.fubar.geek.nz (Postfix) with ESMTPSA id 6212DD7A17; Thu, 14 Jan 2016 10:24:57 +0000 (UTC) Date: Thu, 14 Jan 2016 10:24:56 +0000 From: Andrew Turner To: Steven Hartland Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi Message-ID: <20160114102456.13921bcf@zapp> In-Reply-To: <56977585.4020100@freebsd.org> References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <20160114101343.70e73d01@zapp> <56977585.4020100@freebsd.org> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 10:25:27 -0000 On Thu, 14 Jan 2016 10:16:37 +0000 Steven Hartland wrote: > On 14/01/2016 10:13, Andrew Turner wrote: > > On Thu, 14 Jan 2016 09:22:01 +0000 (UTC) > > Steven Hartland wrote: > > > >> Author: smh > >> Date: Thu Jan 14 09:22:01 2016 > >> New Revision: 293903 > >> URL: https://svnweb.freebsd.org/changeset/base/293903 > >> > >> Log: > >> Fix GCC warnings causing build failure after r293724 > >> > >> Disable some compiler warnings for GCC (non-standard compiler) > >> fixing build failures introduced by r293724, which enabled WARNS in > >> the EFI boot code, when compiling with none standard compiler > >> (GCC). > >> Raised by: ian > >> MFC after: 2 weeks > >> X-MFC-With: r293268 > >> Sponsored by: Multiplay > > The attached would be a better (however untested) solution. Given we > > don't build boot1.efi or loader.efi with gcc it extends this to all > > the EFI code. > > > > Andrew > Not sure I like that idea as it would prevent people using EFI from > having a working system if they also choose GCC. > They already don't have loader.efi or boot1.efi with gcc, how will this patch break their existing system? Andrew