From owner-cvs-src@FreeBSD.ORG Mon Nov 27 13:48:56 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CD3816A512; Mon, 27 Nov 2006 13:48:56 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B0CF43F3A; Mon, 27 Nov 2006 13:46:35 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id kARDlUIe082022; Mon, 27 Nov 2006 16:47:30 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id kARDlTCx082021; Mon, 27 Nov 2006 16:47:30 +0300 (MSK) (envelope-from yar) Date: Mon, 27 Nov 2006 16:47:29 +0300 From: Yar Tikhiy To: Florent Thoumie Message-ID: <20061127134729.GD77085@comp.chem.msu.su> References: <200611261903.kAQJ3KPp013911@repoman.freebsd.org> <20061127130323.GC77085@comp.chem.msu.su> <456AE980.6020304@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <456AE980.6020304@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2006 13:48:56 -0000 On Mon, Nov 27, 2006 at 01:34:56PM +0000, Florent Thoumie wrote: > Yar Tikhiy wrote: > > On Sun, Nov 26, 2006 at 07:03:20PM +0000, Florent Thoumie wrote: > >> flz 2006-11-26 19:03:19 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> etc rc.subr > >> Log: > >> Remove leading dollar sign in rcvar command output. > >> There's no dollar use in variable assignment in sh. > >> Assuming this is can be expected behavior for some > >> people, this change won't be MFC'ed to RELENG_6. > >> > >> Discussed with: yar on -rc > >> > >> Revision Changes Path > >> 1.70 +2 -2 src/etc/rc.subr > > > > Such one-character bogosities are an eyesore but they often take > > enormous effort to be fixed because of complications they have. > > It's no surprise they usually live forever. Thanks for starting > > the fight against this one! > > > > By the way, now the output follows the NetBSD rc.conf style: > > > > # $foo_enable > > foo_enable=YES > > > > Could it be changed even further to match our own rc.conf style? > > I.e.: > > > > # $foo_enable > > foo_enable="YES" > > Yeah, makes sense. There's also a patch in gnats to add a > 'enable/disable' command to rc.subr. I'll try to have a look. If integrating the latter patch, please make sure it handles all places where rc.conf variables can be specified: the files listed in ${rc_conf_files}, the files in /etc/rc.conf.d. However, the feature will hardly be robust to all possible tricks people can use in rc.conf. It's a shell script, after all. I myself use built-in shell commands in rc.conf in some cases, e.g., to have a single rc.conf file for a group of redundant, mostly identical servers. -- Yar