From owner-freebsd-stable Sun Jul 23 16:19: 1 2000 Delivered-To: freebsd-stable@freebsd.org Received: from fnal.gov (heffalump.fnal.gov [131.225.9.20]) by hub.freebsd.org (Postfix) with ESMTP id 1C2BD37B85F for ; Sun, 23 Jul 2000 16:18:55 -0700 (PDT) (envelope-from zingelman@fnal.gov) Received: from nova.fnal.gov ([131.225.18.207]) by smtp.fnal.gov (PMDF V6.0-24 #44770) with ESMTP id <0FY6007J4BFIX4@smtp.fnal.gov> for stable@FreeBSD.ORG; Sun, 23 Jul 2000 18:18:54 -0500 (CDT) Received: from localhost (tez@localhost) by nova.fnal.gov (8.9.3+Sun/8.9.1) with ESMTP id SAA28853; Sun, 23 Jul 2000 18:18:52 -0500 (CDT) Date: Sun, 23 Jul 2000 18:18:52 -0500 (CDT) From: Tim Zingelman Subject: Re: sysinstall resetting USA_RESIDENT=NO In-reply-to: <200007232258.PAA25754@pike.osd.bsdi.com> X-Sender: tez@nova.fnal.gov To: John Baldwin Cc: stable@FreeBSD.ORG Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII X-Authentication-warning: nova.fnal.gov: tez owned process doing -bs Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 23 Jul 2000, John Baldwin wrote: > > In either the case that no make.conf exists, or one exists without a > > USA_RESIDENT line in it, the line is added, regardless of if I have > > confirmed that the default NO is correct or not. > > Hmm, we probably shouldn't do this. I think your first patchset is > actually the proper one. Ultimately, the user needs to choose whether > or not they are in the U.S., we should never choose this for them. Thus, > we should only write anything out if we ask them the question. From what I could tell from mailing list archives, etc. It looked like there was some need to have this set one way or the other, no matter what... though maybe I misinterpreted that... Or as Jordan just suggested, cut it out entirely. As far as that goes, it looks like USAResident could be taken out of the globals too... make it (and my USAResValid) statics in configMake_conf(), have that function ask the question. Though I have not checked to see if configMake_conf() is called running this in scripted mode. I'm willing to take a look. - Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message