From owner-freebsd-rc@FreeBSD.ORG Mon Mar 31 02:06:39 2014 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 00F7A508; Mon, 31 Mar 2014 02:06:39 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.fisglobal.com", Issuer "VeriSign Class 3 Secure Server CA - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AD45B6D0; Mon, 31 Mar 2014 02:06:38 +0000 (UTC) Received: from smarthost.fisglobal.com ([10.132.206.192]) by ltcfislmsgpa07.fnfis.com (8.14.5/8.14.5) with ESMTP id s2V26W4E023544 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 30 Mar 2014 21:06:33 -0500 Received: from THEMADHATTER (10.242.181.54) by smarthost.fisglobal.com (10.132.206.192) with Microsoft SMTP Server id 14.3.174.1; Sun, 30 Mar 2014 21:06:30 -0500 From: Sender: Devin Teske To: "'Jason Hellenthal'" , References: <11c101cf2f6b$e3aee5d0$ab0cb170$@FreeBSD.org> <20140222.141935.520275210006153242.hrs@allbsd.org> <122101cf2f94$bfd81b30$3f885190$@FreeBSD.org> <20140224.125955.1719844232391066.hrs@allbsd.org> <156001cf33dd$f3b5a330$db20e990$@FreeBSD.org> <04c901cf4c5d$a6a4a030$f3ede090$@FreeBSD.org> <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> In-Reply-To: <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> Subject: RE: network.subr _aliasN handling Date: Sun, 30 Mar 2014 19:06:22 -0700 Message-ID: <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQHttkVtKbJQZ7hszActUMJnbew5kAHwlHOYAhb5coEB8/98xQFzxWDoAuXsNgoCNy8pW5pZOlmg Content-Language: en-us X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.87, 1.0.14, 0.0.0000 definitions=2014-03-30_03:2014-03-28,2014-03-30,1970-01-01 signatures=0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: dteske@FreeBSD.org, rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2014 02:06:39 -0000 Never got a go-ahead. What I got was a complaint that I wasn't normalizing, to which I posted a patch and never got a response. =20 Checking the mailing list archives now=E2=80=A6 =20 http://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.htmlhttp= ://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.html =20 =20 Yeah, conversation kinda ended with that last patch. =20 But that wouldn't have deterred me. 30+ days of silence is equivalent to acceptance -- just that I had noticed that the patch could be expanded to include mdconfig{,2} scripts. Was going to wait a full day to see if anyone balked at the expansion to include mdconfig{,2} and then move forward. =20 Happy to move forward now that it appears that general opinion is acceptance (and not by silence). --=20 Devin =20 From: Jason Hellenthal [mailto:jhellenthal@dataix.net]=20 Sent: Sunday, March 30, 2014 5:07 PM To: Cc: Hiroki Sato; ; ; Subject: Re: network.subr _aliasN handling =20 Has any of this been committed this far? I seem to recall mention of a go-a= head but unsure. =20 ? --=20 Jason Hellenthal Voice: 95.30.17.6/616 JJH48-ARIN On Mar 30, 2014, at 17:18, = > wrote: -----Original Message----- From: dteske@FreeBSD.org [mailto:dteske@FreeBS= D.org] Sent: Thursday, February 27, 2014 9:04 AM To: 'Hiroki Sato' Cc: jhellenthal@dataix.net ; lists@jnielsen= .net ; rc@FreeBSD.org ; dteske@FreeBSD.org =20 Subject: RE: network.subr _aliasN handling =20 -----Original Message----- From: Hiroki Sato [mailto:hrs@FreeBSD.org] Sent: Sunday, February 23, 2014 8:00 PM To: dteske@FreeBSD.org =20 Cc: jhellenthal@dataix.net ; lists@jnielsen= .net ; rc@FreeBSD.org =20 Subject: Re: network.subr _aliasN handling =20 > wrote in <122101cf2f94$bfd81b30$3f885190$@FreeBSD.org >: =20 dt> > +list_vars() dt> > +{ dt> > + set | { while read LINE; do dt> > + var=3D"${LINE%%=3D*}" dt> > + case "$var" in dt> > + "$LINE"|*[!a-zA-Z0-9_]*) continue ;; dt> > + $1) echo $var dt> > + esac dt> > + done; } dt> > +} dt> > dt> > This can be inconsistent with normalization of $_if in dt> > get_if_var() when dt> [.-/+] dt> > is included. dt> > dt> [Devin Teske] dt> dt> I'm not sure what you mean by "when [.-/+] is included". The line dt> of code =20 get_if_var() normalizes IF part in the variable name before eval: =20 | _if=3D$1 | _punct=3D". - / +" | for _punct_c in $_punct; do | _if=3D`ltr ${_if} ${_punct_c} '_'` | done =20 while list_vars ifconfig_${_if}_alias[0-9]\* does not. =20 I think this breaks the following configuration, for example: =20 ifconfig_bge0_name=3D"ext.1" ifconfig_ext_1=3D"inet 192.168.0.1/24" ifconfig_ext_1_alias0=3D"inet 192.168.1.1/24" =20 =20 Thanks! Didn't know about that feature. I've attached an updated patch for review which takes this normalization into account I was noticing /etc/rc.d/mdconfig and /etc/rc.d/mdconfig2 exhibit the same behavior, so I've attached a new patch. I didn't find any other instances where a break in the count would stop the loop prematurely. No changes to the old patch, just added mdconfig{,2} to it. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.