From nobody Thu May 25 20:04:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QRzXw5NhFz4Wf79; Thu, 25 May 2023 20:04:32 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QRzXw3kRqz4Hgf; Thu, 25 May 2023 20:04:32 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f3b5881734so3081194e87.0; Thu, 25 May 2023 13:04:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685045070; x=1687637070; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RtWKryacB6ByX99GSzO6p5DQtpCR6WUVLTZb+ohdc24=; b=KrkSL7ezsLAD922KnOnmPohOhJVI8LGgU8zj38vY5LBV1++/EArTLU8xOYkIBsnwHX hPP5Js5S5TrfeyA17M2WdJykdF01HcM6diHwogNeZeuzW8TeoXtJxTHSsVX/xtdmt93O VotNRSgwY1Wm0miH8tWxAB3pT888+DXR1/7JTxoOyvxx5jfCifs04UW7USJiqZ8USZol /AoRQLUmOdO/iBJsrwgCsAgx9o3nox6S1NU31GvaCUlv/w0AGh3sGmfv16OphKbVy04W dQ/TTE2Nm2zusrlzJzIb9Rm3EOX+kUKB1y5/z0ug7Mf9KWwOXqfBO0sTFQeRSfedSe3b tbIQ== X-Gm-Message-State: AC+VfDwuDfB0XZV4gfbdAVLv/kS6r/rNhjvjV/JKPTMWOHwrdodf3NEA T4FTHBgJh8jQVqLUUJAvFBlLbzgpEU2d7zofGwUKRTSY X-Google-Smtp-Source: ACHHUZ7NzG5eJ9MenyJRbNNyn+8qSvfvgfo9gwMuIaJC7O2uL2xyfbw14rIyg/G77EWcWzptgxvlxda97Xz78eRQqU8= X-Received: by 2002:a19:c513:0:b0:4f3:ba53:35f2 with SMTP id w19-20020a19c513000000b004f3ba5335f2mr5725178lfe.49.1685045069673; Thu, 25 May 2023 13:04:29 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202305251622.34PGM6mN060353@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Thu, 25 May 2023 16:04:22 -0400 Message-ID: Subject: Re: git: 01aee8c92d93 - main - libfetch: do not call deprecated OpenSSL functions To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4QRzXw3kRqz4Hgf X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, 25 May 2023 at 12:49, John Baldwin wrote: > > > +#if OPENSSL_VERSION_NUMBER < 0x10100000L > > /* Init the SSL library and context */ > > if (!SSL_library_init()){ > > fprintf(stderr, "SSL library init failed\n"); > > @@ -1211,6 +1212,7 @@ fetch_ssl(conn_t *conn, const struct url *URL, int verbose) > > } > > > > SSL_load_error_strings(); > > +#endif > > Should we just remove this code outright? I don't think there's any value in > supporting pre-1.1 OpenSSL versions? Indeed that should be our end goal, but my initial desire is for minimal changes. I also think there's some value in having these functions as placeholders for now, in case anything with OpenSSL's automatic init doesn't work as expected.