Date: Sat, 27 May 2023 08:17:12 +0000
From: bugzilla-noreply@freebsd.org
To: ports-bugs@FreeBSD.org
Subject: [Bug 271374] emulators/mame-0.254 fails to build on {arm64,amd64,i386}-14-CURRENT
Message-ID: <bug-271374-7788-sSfLbueq8J@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-271374-7788@https.bugs.freebsd.org/bugzilla/>
References: <bug-271374-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271374 --- Comment #26 from Robert Clausecker <fuz@FreeBSD.org> --- (In reply to Alastair Hogge from comment #25) Looks cool! Here are some things I found: - do-install-DEBUG-on and do-install-DEBUG-off do the same thing and can be merged; just put the commands into do-install - I recommend that you keep the mention of armv7 in the comment above LDFL= AGS. Else a future maintainer might test on amd64 and find that it is not nee= ded, breaking the port once more (you won't believe how often that happens). - the conditionals for the QTDEBUGGER option are commented out. Is this correct? You can rewrite them like such: QTDEBUGGER_MAKE_ENV=3D USE_QTDEBUG=3D1 QTDEBUGGER_USES=3D qt:5 QTDEBUGGER_USE=3D qt=3Dcore,gui,widgets,buildtools:build,qmake:build - in OVERRIDE_CC for FreeBSD > 14, you should not use COMPILER_TYPE as it could be gcc. Just write e.g. clang++${LLVM_VERSION}. - check if you can use DISTVERSION instead of PORTVERSION as per policy - would it make sense to make TOOLS=3D1 a port option so people can get a = leaner mame if they want? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271374-7788-sSfLbueq8J>