From owner-p4-projects@FreeBSD.ORG Fri Aug 4 14:57:52 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 992B116A4DF; Fri, 4 Aug 2006 14:57:52 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B74916A4EF for ; Fri, 4 Aug 2006 14:57:52 +0000 (UTC) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2691843D45 for ; Fri, 4 Aug 2006 14:57:52 +0000 (GMT) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k74Evq3k097629 for ; Fri, 4 Aug 2006 14:57:52 GMT (envelope-from piso@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k74EvpSw097626 for perforce@freebsd.org; Fri, 4 Aug 2006 14:57:51 GMT (envelope-from piso@freebsd.org) Date: Fri, 4 Aug 2006 14:57:51 GMT Message-Id: <200608041457.k74EvpSw097626@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to piso@freebsd.org using -f From: Paolo Pisati To: Perforce Change Reviews Cc: Subject: PERFORCE change 103173 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 14:57:52 -0000 http://perforce.freebsd.org/chv.cgi?CH=103173 Change 103173 by piso@piso_newluxor on 2006/08/04 14:57:30 taskqueue_free() executes all the tasks still pending on that taskqueue: in this case, taskqueue_drain() is superfluous. Affected files ... .. //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#6 edit Differences ... ==== //depot/projects/soc2006/intr_filter/dev/bfe/if_bfe.c#6 (text+ko) ==== @@ -475,8 +475,6 @@ device_delete_child(dev, sc->bfe_miibus); bfe_release_resources(sc); - taskqueue_drain(sc->sc_tq, &sc->sc_stoptask); - taskqueue_drain(sc->sc_tq, &sc->sc_errorstask); taskqueue_free(sc->sc_tq); BFE_UNLOCK(sc); mtx_destroy(&sc->bfe_mtx);