From owner-cvs-all@FreeBSD.ORG Fri Jun 22 19:44:19 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 01E5D16A41F for ; Fri, 22 Jun 2007 19:44:19 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id C60C413C457 for ; Fri, 22 Jun 2007 19:44:18 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 55405 invoked from network); 22 Jun 2007 15:28:02 -0000 Received: from ppp-71-139-42-13.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.42.13) by root.org with ESMTPA; 22 Jun 2007 15:28:02 -0000 Message-ID: <467BEA7C.4090801@root.org> Date: Fri, 22 Jun 2007 08:27:56 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070511) MIME-Version: 1.0 To: Kris Kennaway References: <200706220255.l5M2tH83097833@repoman.freebsd.org> <20070622073829.GA2707@rot26.obsecurity.org> In-Reply-To: <20070622073829.GA2707@rot26.obsecurity.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, portmgr@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11/libX11/files patch-src::GetMoEv.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2007 19:44:19 -0000 Kris Kennaway wrote: > On Fri, Jun 22, 2007 at 02:55:16AM +0000, Nate Lawson wrote: >> njl 2007-06-22 02:55:16 UTC >> >> FreeBSD ports repository (src committer) >> >> Added files: >> x11/libX11/files patch-src::GetMoEv.c >> Log: >> Add a temporary patch for an argument ordering bug introduced during a >> code cleanup. This bug caused gimp to crash when clicking/dragging. >> I'll let the maintainers fix this however they want to, meanwhile this >> patch is critical to usability. Discussion: >> http://lists.freebsd.org/pipermail/freebsd-x11/2007-June/004649.html >> >> Bug id: 11222 > > Nate, > > Ports committers don't make unreviewed commits to e.g. APCI code, so > we'd appreciate it if you'd do us the courtesy of returning the > favour. > > This port has a maintainer, and if you'd raised your concerns there > you would have learned that a fix for this is in progress. > > Kris, for portmgr Sorry for violating the process. I did fully test the patch and it was an obvious mistake in the code. If I break ACPI by reordering arguments and don't fix it within an hour (vs. 7 days), I wouldn't mind another committer patching things until I got back. -- Nate