From owner-svn-src-head@freebsd.org Sat Apr 8 22:16:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 420B4D3583F for ; Sat, 8 Apr 2017 22:16:56 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC547A40 for ; Sat, 8 Apr 2017 22:16:55 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk0-x233.google.com with SMTP id p68so60757699qke.1 for ; Sat, 08 Apr 2017 15:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q8WCjixt1g0EiukXVAmcgrfgchmdq9VeFEzScL6YrXc=; b=U0Kjgd1CPkIgqth4yCJpiih3xH3QhgdCvhEZM/hjJ1M7oHbQr18EtkJGWIFH+IG49x SnzIIGQMgrVIh+OBUXQ9/9mRBT0gF18QeaSpCUnAp8bGMRZpMSeBXKSJJBZgqr+Jt3L2 EcJM8Cw5kdmBFIf06gv1X7ufr4nri7iIe41qxxup+F9OXlztbenpirFmssDm4vJZi6m8 ybPYHDgHIlQG1MV9mj7fTIZHeHZ7PwtFw7n1ose8wjPmBFbOhMfQaqE2DbAdG2QghPsX ZrxQ6NzO5MI1VYg8o7z0j7nIAIDRh4Bazo7yLZISY2inUjrtYDNpQIHCVQxiNPeXMmBB LbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q8WCjixt1g0EiukXVAmcgrfgchmdq9VeFEzScL6YrXc=; b=IV4CR33aD2nzA+COCGxVG2GvottiZvQuII5FuVj/mpsZGqLjZFAe7wcC/zwE8oHytO GtYvuKZhgHp+G7qKYm0n2f32lUuR9ls/DJBPMtj6a09+eIZwaeJXd1eY1AI/nGKWOabi NKKsjDWY7EfxA6N9YGCEY0palyQfp7IEiQ33iClU55Dpjnm+k4MC7oBDudAfdzMx8YQI JgS0tXYW68RVtgSLY5mJprttvMb2ZsC1ex6TOnz6wYuKiyRkWk84kkovl9ErYef4m0Xn EivkYa1D+VR6X09CQ1iJua99zZdBWwqHuGk75DadoXltoQGjehkjVg+52sRES3xYeK7L f3hw== X-Gm-Message-State: AFeK/H1VAAhIOHXVtQ6fIWzFPYbw/F15ZAcGu6Yu1ohAvGevU3kQDf5luIzdtq6Wqs23kJ1X X-Received: by 10.55.160.209 with SMTP id j200mr43006223qke.57.1491689815043; Sat, 08 Apr 2017 15:16:55 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-218-40.bltmmd.fios.verizon.net. [100.16.218.40]) by smtp.gmail.com with ESMTPSA id a26sm5825469qtb.28.2017.04.08.15.16.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 08 Apr 2017 15:16:54 -0700 (PDT) Date: Sat, 8 Apr 2017 18:16:53 -0400 From: Shawn Webb To: Toomas Soome Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs Message-ID: <20170408221653.qtqdvgcosguvugtt@mutt-hbsd> References: <201704061817.v36IHT8i088712@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="alzeaugu3mdk6utq" Content-Disposition: inline In-Reply-To: <201704061817.v36IHT8i088712@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20170206 (1.7.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Apr 2017 22:16:56 -0000 --alzeaugu3mdk6utq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 06, 2017 at 06:17:29PM +0000, Toomas Soome wrote: > Author: tsoome > Date: Thu Apr 6 18:17:29 2017 > New Revision: 316585 > URL: https://svnweb.freebsd.org/changeset/base/316585 >=20 > Log: > loader: zfs reader should check all labels > =20 > The current zfs reader is only checking first label from each device, h= owever, > we do have 4 labels on device and we should check all 4 to be protected > against disk failures and incomplete label updates. > =20 > The difficulty is about the fact that 2 label copies are in front of the > pool data, and 2 are at the end, which means, we have to know the size = of > the pool data area. > =20 > Since we have now the mechanism from common/disk.c to use the partition > information, it does help us in this task; however, there are still some > corner cases. > =20 > Namely, if the pool is created without partition, directly on the disk, > and firmware will give us the wrong size for the disk, we only can check > the first two label copies. > =20 > Reviewed by: allanjude > Differential Revision: https://reviews.freebsd.org/D10203 This breaks bhyve userboot: # sh /usr/share/examples/bhyve/vmrun.sh -c 8 -m 16g -t tap4 -C /dev/nmdm-la= ptop-dev-03-A -d /dev/zvol/enctank/bhyve/laptop-dev-03/disk-01 laptop-dev-03 /boot/userboot.so: Undefined symbol "ldi_get_size" Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --alzeaugu3mdk6utq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAljpYVIACgkQaoRlj1JF bu5NqQ//eZMwx7fP1aU5I7LaJlxsqnh8bnKAxvEg9vDs2dHProTKRrdeDl8ozk1c /Ag661kWs+jGeIP84v8mSIGJedcQ2aphy3MwNg1o6BP2cWTcqW+Ij49ZJxKgMQHS AnZiB89wXmglwAlJlywVoK3weVhVjj4C9hq+FAJbPtYgsFWgjY2RQUs/M2fNzlEk 7Pnkg1bwvs0nhKuJseEGaXukOsbLxi66+qTep5wrS7iZnAIEkLUNKhj9T1UU4s4q lsesz9XCvmSY/frfxTJii70L5f2RCABfPj/MTbFBDX4veDCyW5OuNxeqCI8UtzNX efojtq/OIbYb5/AL8L6JffU/AYmOcoN+V3deErOU63saOkU1yxSqRnGzZuDoUflU z1f505Gb6l4nCsCdqQKo/S+QprsSsOK8C0ppSrKkrhbxHU3Bs3kcnOE2GrYceQwm n93ZRWcxNuqdOGDQH+DlVSMDzYvKOVikO96Ejj0XQrQNJK6stf1qPLuMm/F19E0r kT5a1UZCksx4O0uNX8jWIq7YL6LWd84pp4Twy0d20JmftT97Q7803LfeKf1z0fix eiLSne3oiltSS5qZI98u8N7/Cn9zTb2O0zpHjqPrebhOLPqcm6FjAceE3cSQ9MU4 xziofIgsC6EEARUxLG/8cxbGZZLGybTEpPuIQDzVCFlyhW2asAs= =f8/u -----END PGP SIGNATURE----- --alzeaugu3mdk6utq--