From owner-svn-src-head@FreeBSD.ORG  Mon Nov 19 00:01:57 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C7830341;
 Mon, 19 Nov 2012 00:01:57 +0000 (UTC)
 (envelope-from freebsd@damnhippie.dyndns.org)
Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214])
 by mx1.freebsd.org (Postfix) with ESMTP id EFA028FC17;
 Mon, 19 Nov 2012 00:01:50 +0000 (UTC)
Received: from damnhippie.dyndns.org (daffy.symmetricom.us [206.168.13.218])
 by duck.symmetricom.us (8.14.5/8.14.5) with ESMTP id qAJ01nBw072955;
 Sun, 18 Nov 2012 17:01:49 -0700 (MST)
 (envelope-from freebsd@damnhippie.dyndns.org)
Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240])
 by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id qAJ01j58028796;
 Sun, 18 Nov 2012 17:01:45 -0700 (MST)
 (envelope-from freebsd@damnhippie.dyndns.org)
Subject: Re: svn commit: r243228 - head/etc
From: Ian Lepore <freebsd@damnhippie.dyndns.org>
To: Chris Rees <utisoft@gmail.com>
In-Reply-To: <CADLo83-RM8dQTQZ7HdQPHvyZ1aHQpqFfGOp6x51-gTtqGL84=g@mail.gmail.com>
References: <201211181421.qAIEL5KT042019@svn.freebsd.org>
 <CAJOYFBBWmm_eoS9qOYMxigtS+SjafXXVeT_BmgdWFgEF69j+Nw@mail.gmail.com>
 <CADLo83-RM8dQTQZ7HdQPHvyZ1aHQpqFfGOp6x51-gTtqGL84=g@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Date: Sun, 18 Nov 2012 17:01:45 -0700
Message-ID: <1353283305.1217.324.camel@revolution.hippie.lan>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, Ed Schouten <ed@80386.nl>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Nov 2012 00:01:57 -0000

On Sun, 2012-11-18 at 21:59 +0000, Chris Rees wrote:
> On 18 Nov 2012 20:39, "Ed Schouten" <ed@80386.nl> wrote:
> >
> > Hi Chris,
> >
> > 2012/11/18 Chris Rees <crees@freebsd.org>:
> > > Modified: head/etc/rc.initdiskless
> > >
> ==============================================================================
> > > --- head/etc/rc.initdiskless    Sun Nov 18 14:05:28 2012
>  (r243227)
> > > +++ head/etc/rc.initdiskless    Sun Nov 18 14:21:05 2012
>  (r243228)
> > > @@ -354,7 +354,7 @@ for i in ${templates} ; do
> > >         subdir=${j##*/}
> > >         if [ -d $j -a ! -f $j.cpio.gz  ]; then
> > >             create_md $subdir
> > > -           cp -Rp $j/ /$subdir
> > > +           (cd $j && pax -rw . /$subdir)
> > >         fi
> > >      done
> > >      for j in /conf/$i/*.cpio.gz ; do
> >
> > Are you sure that this bug wasn't already fixed? The original version
> > of the code in the bug report used the following line:
> >
> > -           cp -Rp $j/* /$subdir
> >
> > The old version of the code you changed didn't have this asterisk,
> > meaning dotfiles would already be copied. Still, you could argue that
> > your version is nicer, as our behaviour of cp with the trailing slash
> > contradicts POSIX.
> >
> 
> You are correct, and the second to point it out :)
> 
> As you say however, pax is technically how it should be done anyway, and
> has the nice effect of also preserving hard links.  If no-one objects I
> think it should stay in.
> 
> This is unfortunately another example of many in rc of where something was
> fixed ages ago and no-one checked GNATS :(  Of course, this is still my
> fault.

I would vote against yet another pointlessly different program required
to boot the system.  At work, we don't put pax (or anything else we
don't need) onto a product image (although if this change sticks, I
guess we will be some day).

-- Ian