From owner-svn-src-head@freebsd.org Wed Mar 8 16:19:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14578D031C8 for ; Wed, 8 Mar 2017 16:19:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCB7C1457 for ; Wed, 8 Mar 2017 16:19:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x235.google.com with SMTP id g138so40848104itb.0 for ; Wed, 08 Mar 2017 08:19:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=kpLCH8LM0rz87/GF258lK8avR5IMqqdGO6fPZ37VfBM=; b=fl8Y2Etd+1NnrKPaLO40eH4qQEl74Teal3K22t1SPBJ8VJ+NvvPBrjiCBWZshmZAeI 7tbAxR2lC5YOXzjvTJn9HyOFv8tEisE123HyC67mJVJJ/vxDSJYHqzKhy+6EK8axlYQk bOHaMLfjIjqivHswINFVlQCQFJA/r3Pj6idAh0FE4YZsC3QMNCv6Pcw08qeWWL6hkd1P cuagyMNM0FoZ12bjE74obFU+tkqhTa05m+FZdzDTFt0MS9F05D0aKGYShd0pDXj4a3xI pmkV+17T1WXBMfTgwXFX3yysBgH6bAJnciBdm0TylDEAq7Sxqt75RqIuC96WvYF8LtzB ZTcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=kpLCH8LM0rz87/GF258lK8avR5IMqqdGO6fPZ37VfBM=; b=phMVuELknQVbDSCwTW8mZyB8AmryNzrI3wIJlNVRosA55+uPVUqGB9Myog5M41MAlK Tv2umf0Yt1UYMNY3EkNevH7Wlvfg9/gUtCQarKD8Y7lfjht+SBKm+TwOCr4MIAlBpKB9 BVCag0mgUbU7VMjKbkjN0ojflO124uTNxml6VmUtmRCZp69hphPZ4TxK5i9l+V9vs0sQ bqhEXLh+ugrsum0kyZWq5EViBqteOzBZMCWRCMLgwNyr6DRBTPHqp16c3FBYBiVy5OsI QjKvVAO6pz6dn57bcY6vXC3ugTsrU2rCkjBdm0po3oz9jAnB+8lt42d4WWf9xZ+C6u01 Wf6g== X-Gm-Message-State: AMke39mlEwIeGy3jg0bBMJp3OJX/KAIgxe0Sm0l44o4oBbooId6eTCA1tucEbzTozRBYuaXNhmZsmO8wd1KrrA== X-Received: by 10.107.198.193 with SMTP id w184mr7015078iof.19.1488989983070; Wed, 08 Mar 2017 08:19:43 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Wed, 8 Mar 2017 08:19:42 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <201703081607.v28G7a6E001322@pdx.rh.CN85.dnsmgr.net> References: <201703081109.v28B9RCD000618@repo.freebsd.org> <201703081607.v28G7a6E001322@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 8 Mar 2017 09:19:42 -0700 X-Google-Sender-Auth: -gmMxH_CNEQ3Y81_q9tlkQh0xUM Message-ID: Subject: Re: svn commit: r314905 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf modules/linuxkpi To: rgrimes@freebsd.org Cc: Hans Petter Selasky , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 16:19:44 -0000 On Wed, Mar 8, 2017 at 9:07 AM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: hselasky >> Date: Wed Mar 8 11:09:27 2017 >> New Revision: 314905 >> URL: https://svnweb.freebsd.org/changeset/base/314905 >> >> Log: >> Cleanup the LinuxKPI slab implementation. >> >> Put large functions into linux_slab.c instead of declaring them static >> inline. >> >> Add support for more memory allocation wrappers like kmalloc_array() >> and __vmalloc(). >> >> Make sure either the M_WAITOK or the M_NOWAIT flag is set and mask >> away unused memory allocation flags before calling FreeBSD's malloc() >> routine. >> >> Move kmalloc_node() definition to slab.h where it belongs. >> >> Implement support for the SLAB_DESTROY_BY_RCU feature when creating a >> kmem_cache which basically means kmem_cache memory is freed using >> call_rcu(). >> >> MFC after: 1 week >> Sponsored by: Mellanox Technologies >> >> Added: >> head/sys/compat/linuxkpi/common/src/linux_slab.c (contents, props changed) >> Modified: >> head/sys/compat/linuxkpi/common/include/linux/gfp.h >> head/sys/compat/linuxkpi/common/include/linux/slab.h >> head/sys/conf/files >> head/sys/modules/linuxkpi/Makefile >> >> Modified: head/sys/compat/linuxkpi/common/include/linux/gfp.h >> ============================================================================== >> --- head/sys/compat/linuxkpi/common/include/linux/gfp.h Wed Mar 8 09:53:20 2017 (r314904) >> +++ head/sys/compat/linuxkpi/common/include/linux/gfp.h Wed Mar 8 11:09:27 2017 (r314905) >> @@ -168,8 +168,6 @@ gfpflags_allow_blocking(const gfp_t gfp_ >> return ((gfp_flags & (M_WAITOK | M_NOWAIT)) == M_WAITOK); >> } >> >> -#define kmalloc_node(chunk, mask, node) kmalloc(chunk, mask) >> - >> #define SetPageReserved(page) do { } while (0) /* NOP */ >> #define ClearPageReserved(page) do { } while (0) /* NOP */ >> >> >> Modified: head/sys/compat/linuxkpi/common/include/linux/slab.h >> ============================================================================== >> --- head/sys/compat/linuxkpi/common/include/linux/slab.h Wed Mar 8 09:53:20 2017 (r314904) >> +++ head/sys/compat/linuxkpi/common/include/linux/slab.h Wed Mar 8 11:09:27 2017 (r314905) >> @@ -2,7 +2,7 @@ >> * Copyright (c) 2010 Isilon Systems, Inc. >> * Copyright (c) 2010 iX Systems, Inc. >> * Copyright (c) 2010 Panasas, Inc. >> - * Copyright (c) 2013, 2014 Mellanox Technologies, Ltd. >> + * Copyright (c) 2013-2017 Mellanox Technologies, Ltd. > > Though widly seen, often miss understood, this modification technically under the copyright > law can be used to assert that you have claimed copyright on the 2014 work more than one > year after original poublication, hence the work done in 2014 now falls under different > parts of the US copyright law. A prefered form of the above dates would be > 2013-2014, 2017. Do not assert copyrights for years in which no new material was > published. Publishes is defferent than written. Do not interpret these dates > as the dates written. > > Effect of this type of error: > According to the U.S. Copyright Act, if the year date [in the copyright > notice] is more than one year later than the year in which publication first > occurred, the work is considered to have been published without any notice. This is incorrect legal advice. Please don't give out legal advice if you are not a lawyer. The copyright office's own page says you need only list the first year of publication on the list of years[*]. The project's guidance to committers for the last 20 years is to do a range of copyright dates. If you'd believe this is in error, please work with the FreeBSD Foundation to get their lawyers to offer updated guidance. Warner [*] https://www.copyright.gov/circs/circ03.pdf