From owner-svn-src-head@FreeBSD.ORG Sat Jul 13 17:44:35 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2531A7B2; Sat, 13 Jul 2013 17:44:35 +0000 (UTC) (envelope-from gleb.kurtsou@gmail.com) Received: from mail-pb0-x232.google.com (mail-pb0-x232.google.com [IPv6:2607:f8b0:400e:c01::232]) by mx1.freebsd.org (Postfix) with ESMTP id E5E291AA2; Sat, 13 Jul 2013 17:44:34 +0000 (UTC) Received: by mail-pb0-f50.google.com with SMTP id wz7so9887430pbc.23 for ; Sat, 13 Jul 2013 10:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=f8/afkrUHURPIS2dmewcgD4zrAPAMtYSzSOHlLDNNDg=; b=kO2i9g8V0TbAraMYyUdnl/37cUxvfDh1gibLbc7Nog2os2liY+FGeHeLcmgDr9ikUv 7IKLczbPXwzHvBp1LFF/PKLniRWZMPfOf5nl46pIRUVhiRNAPnPQl3t2MMxysuJkkcLj Ky75iuEr6QkXBS9w2BV8maVKyeeJAkGwDcRBNcXrFCL+SzCXkhDYfaZWkHarLPqkWfax PObWJKaeLDMopZzaq6IN7qcu9H8/z/2x6DCyx6WuhttPi6zGbDH3UETMm9rAkApxjfoR tbUlU10ZUo+glXEj2OCIA4hrSVuEkPbra8BsA7dhOntoZNUGuJH+V9kNRPU3/eLLzTOC ZU7A== X-Received: by 10.66.150.9 with SMTP id ue9mr44869603pab.88.1373737474688; Sat, 13 Jul 2013 10:44:34 -0700 (PDT) Received: from localhost (c-67-188-139-74.hsd1.ca.comcast.net. [67.188.139.74]) by mx.google.com with ESMTPSA id ep4sm24161846pbd.35.2013.07.13.10.44.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 13 Jul 2013 10:44:33 -0700 (PDT) Sender: Gleb Kurtsou Date: Sat, 13 Jul 2013 10:44:55 -0700 From: Gleb Kurtsou To: "Pedro F. Giffuni" Subject: Re: svn commit: r253276 - head/sys/fs/fuse Message-ID: <20130713174455.GA1108@reks> References: <201307121722.r6CHMxAs083287@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201307121722.r6CHMxAs083287@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jul 2013 17:44:35 -0000 On (12/07/2013 17:22), Pedro F. Giffuni wrote: > Author: pfg > Date: Fri Jul 12 17:22:59 2013 > New Revision: 253276 > URL: http://svnweb.freebsd.org/changeset/base/253276 > > Log: > Add creation timestamp (birthtime) support for fuse. > > This is based on similar support in MacFUSE. Looks like it breaks backward compatibility, do we want to preserve it taking into account that there was on fusefs official release as part of base but we had fuse in ports for a while? fusefs-libs seems to have its own version of fuse_kernel.h. There are fuse file system implementations that skip libfuse entirely (glusterfs? I'm not sure). At least we should have bumped fuse version.. Thanks, Gleb. > > Modified: > head/sys/fs/fuse/fuse_internal.h > head/sys/fs/fuse/fuse_kernel.h > > Modified: head/sys/fs/fuse/fuse_internal.h > ============================================================================== > --- head/sys/fs/fuse/fuse_internal.h Fri Jul 12 17:11:30 2013 (r253275) > +++ head/sys/fs/fuse/fuse_internal.h Fri Jul 12 17:22:59 2013 (r253276) > @@ -223,6 +223,8 @@ fuse_internal_attr_fat2vat(struct mount > vap->va_mtime.tv_nsec = fat->mtimensec; > vap->va_ctime.tv_sec = fat->ctime; > vap->va_ctime.tv_nsec = fat->ctimensec; > + vap->va_birthtime.tv_sec = fat->crtime; > + vap->va_birthtime.tv_nsec = fat->crtimensec; > vap->va_blocksize = PAGE_SIZE; > vap->va_type = IFTOVT(fat->mode); > > > Modified: head/sys/fs/fuse/fuse_kernel.h > ============================================================================== > --- head/sys/fs/fuse/fuse_kernel.h Fri Jul 12 17:11:30 2013 (r253275) > +++ head/sys/fs/fuse/fuse_kernel.h Fri Jul 12 17:22:59 2013 (r253276) > @@ -69,9 +69,15 @@ struct fuse_attr { > __u64 atime; > __u64 mtime; > __u64 ctime; > +#ifdef __FreeBSD__ > + __u64 crtime; > +#endif > __u32 atimensec; > __u32 mtimensec; > __u32 ctimensec; > +#ifdef __FreeBSD__ > + __u32 crtimensec; > +#endif > __u32 mode; > __u32 nlink; > __u32 uid;