Date: Sat, 7 Sep 2013 01:02:36 +0200 From: Jeremie Le Hen <jlh@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: freebsd-hackers@freebsd.org, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: [RFC][CFT] GEOM direct dispatch and fine-grained CAM locking Message-ID: <20130906230236.GI43281@caravan.chchile.org> In-Reply-To: <52299257.10704@FreeBSD.org> References: <5224511D.4090503@FreeBSD.org> <20130903134251.GB43281@caravan.chchile.org> <CAKYr3zwjQ9K1c5smZXTESa3T5UnchYaipYQCS2OAJOUFyPBGww@mail.gmail.com> <CA%2Bq%2BTcoeHDbkCOXvBjbbzOKCbb7RLYqG0jn9bHNn_CZgLGarLg@mail.gmail.com> <5226DAB0.1060303@FreeBSD.org> <CA%2Bq%2BTcoKg-FuuKt_L9W8rGc_ZEv9XOteq=x6N%2BVT9_mUhRJDHQ@mail.gmail.com> <5228F9D4.3060008@FreeBSD.org> <CA%2Bq%2BTcrW%2B73JeUw9nxTcCdXTu578n25n_E_2Z9FDB1RGZ0_5cg@mail.gmail.com> <20130906080627.GH43281@caravan.chchile.org> <52299257.10704@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 06, 2013 at 11:29:11AM +0300, Alexander Motin wrote: > On 06.09.2013 11:06, Jeremie Le Hen wrote: > > On Fri, Sep 06, 2013 at 12:46:27AM +0200, Olivier Cochard-Labbé wrote: > >> On Thu, Sep 5, 2013 at 11:38 PM, Alexander Motin <mav@freebsd.org> wrote: > >>> I've found and fixed possible double request completion, that could cause > >>> such symptoms if happened. Updated patch located as usual: > >>> http://people.freebsd.org/~mav/camlock_patches/camlock_20130905.patch > >>> > > With this new one I cannot boot any more (I also updated the source > > tree). This is a hand transcripted version: > > > > Trying to mount root from zfs:zroot/root []... > > panic: Batch flag already set > > cpuid = 1 > > KDB: stack backtrace: > > db_trace_self_wrapper() > > kdb_backtrace() > > vpanic() > > kassert_panic() > > xpt_batch_start() > > ata_interrupt() > > softclock_call_cc() > > softclock() > > ithread_loop() > > fork_exit() > > fork_trampoline() > > Thank you for the report. I see my fault. It is probably specific to > ata(4) driver only. I've workarounded that in new patch version, but > probably that area needs some rethinking. > > http://people.freebsd.org/~mav/camlock_patches/camlock_20130906.patch I'm not sure you needed a confirmation, but it boots. Thanks :). I didn't quite understand the thread; is direct dispatch enabled for amd64? ISTR you said only i386 but someone else posted the macro for amd64. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130906230236.GI43281>