From owner-cvs-all Fri Dec 7 4:23:35 2001 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 3108737B416; Fri, 7 Dec 2001 04:23:29 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 0F6AC14C56; Fri, 7 Dec 2001 13:23:28 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrew R. Reiter" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_stf.c References: <200112070132.fB71WfJ26422@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: 07 Dec 2001 13:23:27 +0100 In-Reply-To: <200112070132.fB71WfJ26422@freefall.freebsd.org> Message-ID: Lines: 16 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrew R. Reiter" writes: > Log: > - malloc should be passed M_WAITOK, not M_WAIT (a mbuf flag) > - make use of M_ZERO to remove a call to bzero() There are a couple more: des@des ~/www_docs/freebsd/diary% kcurrent -w M_WAIT | grep malloc src/sys/dev/digi/digi.c: sc->bios.data = malloc(sc->bios.size, M_TTYS, M_WAIT); src/sys/dev/digi/digi.c: sc->fep.data = malloc(sc->fep.size, M_TTYS, M_WAIT); src/sys/dev/digi/digi.c: sc->link.data = malloc(sc->link.size, M_TTYS, M_WAIT); src/sys/net/if_stf.c: sc = malloc(sizeof(struct stf_softc), M_STF, M_WAIT); DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message