From owner-svn-src-all@FreeBSD.ORG Thu Oct 14 23:28:31 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFB5A106566B; Thu, 14 Oct 2010 23:28:31 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 9DA048FC19; Thu, 14 Oct 2010 23:28:31 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o9ENSVlH041588; Thu, 14 Oct 2010 23:28:31 GMT (envelope-from obrien@svn.freebsd.org) Received: (from obrien@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o9ENSVRX041585; Thu, 14 Oct 2010 23:28:31 GMT (envelope-from obrien@svn.freebsd.org) Message-Id: <201010142328.o9ENSVRX041585@svn.freebsd.org> From: "David E. O'Brien" Date: Thu, 14 Oct 2010 23:28:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r213883 - head/tools/regression/bin/sh/builtins X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2010 23:28:31 -0000 Author: obrien Date: Thu Oct 14 23:28:31 2010 New Revision: 213883 URL: http://svn.freebsd.org/changeset/base/213883 Log: Embellish this testcase a little bit to be more clear what the output is and why. The first case is correct usage which has but one correct output. The 2nd and 3rd cases are incorrect usage in which the exact output is not standardized and various shells give various allowable output. Modified: head/tools/regression/bin/sh/builtins/getopts1.0 head/tools/regression/bin/sh/builtins/getopts1.0.stdout Modified: head/tools/regression/bin/sh/builtins/getopts1.0 ============================================================================== --- head/tools/regression/bin/sh/builtins/getopts1.0 Thu Oct 14 23:26:08 2010 (r213882) +++ head/tools/regression/bin/sh/builtins/getopts1.0 Thu Oct 14 23:28:31 2010 (r213883) @@ -1,12 +1,25 @@ # $FreeBSD$ + +echo '-1-' set -- -abc getopts "ab:" OPTION echo ${OPTION} +# In this case 'getopts' should realize that we have not provided the +# required argument for "-b". +# Note that Solaris 10's (UNIX 03) /usr/xpg4/bin/sh, /bin/sh, and /bin/ksh; +# ksh93 20090505; pdksh 5.2.14p2; mksh R39c; bash 4.1 PL7; and zsh 4.3.10. +# all recognize that "b" is missing its argument on the *first* iteration +# of 'getopts' and do not produce the "a" in $OPTION. +echo '-2-' set -- -ab getopts "ab:" OPTION echo ${OPTION} +getopts "ab:" OPTION +echo ${OPTION} +# The 'shift' is aimed at causing an error. +echo '-3-' shift 1 getopts "ab:" OPTION echo ${OPTION} Modified: head/tools/regression/bin/sh/builtins/getopts1.0.stdout ============================================================================== --- head/tools/regression/bin/sh/builtins/getopts1.0.stdout Thu Oct 14 23:26:08 2010 (r213882) +++ head/tools/regression/bin/sh/builtins/getopts1.0.stdout Thu Oct 14 23:28:31 2010 (r213883) @@ -1,3 +1,8 @@ +-1- a +-2- a +No arg for -b option +? +-3- ?