From owner-svn-src-head@freebsd.org Thu Feb 28 21:51:20 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2E47151AB16; Thu, 28 Feb 2019 21:51:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 28E3E8B1F1; Thu, 28 Feb 2019 21:51:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x644.google.com with SMTP id c4so10368026pls.11; Thu, 28 Feb 2019 13:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1fvyOwoVNEyl3i5lV5XiXFYP1F2NPk7+NGBQfDLkxWE=; b=qChzzMJ4RQ/aRZfmvoaYQmTCf2Ua9Cshiu5J2/vhrs9m1l/rF53WAd6aHgXw0/XOUa 0NeRXztCCb3yfxNnY56Uf0C4eTiP7WSs8gs6c/cdIFyPl4D35grGjP9ecH6yL3sK3Wfk gufG+WKgzZzznzpyRNO7E+vRv0NAafhJ3r+OGNYR7suFbLJuWhUpOZJY3+nkXS6tpqAn 4bEaOFoJhRcR61DpkOzDqigosajXNVAuC6GVrDHM4xMbCWR+leTiVR7MzCwqWwk85+rh niGBbQ2xWrG8xYxDEjKbx/mWjQQkuEUEpfyVKFi61qpUqZpXwoO85exwvIO5eHC4Gh8Z IE0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1fvyOwoVNEyl3i5lV5XiXFYP1F2NPk7+NGBQfDLkxWE=; b=S8SS8bckAFDmol5HaSWttwAVq0BwCOoN2uTxKq8pvaX4sWyvzwbBICsIjrkmh6kviZ EwrQlxTmJEAqouaY/oVrgNiKr18pACwHES4JQWpuTeFrEKJ7jM19tB7zIOt0QipaeD+y JLCF0tzlLnxShXzH97FzY7d3KHP0ziyXKZxI3CK915r1TPT/el+fjNC9HbJxOXjiy18C DRDxJmCXLSBYZzzzXUCnXOnz9MMJcdwH/vtI9S/TUsKnI0OCTKIU2ElEg87tAt30t4T9 u1KTLY1uOZWWZTqG0FmprJuXMHIbf7l4PYjjHcP8gbsrG3x2fNEGd/0sy3LHxXzYFrKp Ot8A== X-Gm-Message-State: APjAAAV67YniI2VB0WCdvU5YowNZ7lIr3tM7lmp7jwB+5j+nwSWtq16h zdd8wmElsjjLnXQyQIzJCjSX2Ora X-Google-Smtp-Source: APXvYqzYIEm+F0S76I2XFhRKPSVE4OYsZQXSjE2y4VRimhb1QihUSkuhpTYwJ6mvrBQEFm/Ke1pfQQ== X-Received: by 2002:a17:902:9a02:: with SMTP id v2mr1639418plp.201.1551390678670; Thu, 28 Feb 2019 13:51:18 -0800 (PST) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x8sm27923083pfn.137.2019.02.28.13.51.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 13:51:17 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344666 - head/tools/build/mk From: Enji Cooper In-Reply-To: Date: Thu, 28 Feb 2019 13:51:17 -0800 Cc: Bryan Drewery , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5B91E4F8-C563-466D-A8FC-61A26F164109@gmail.com> References: <201902282048.x1SKmILE082786@repo.freebsd.org> <0EC04D65-721E-49F1-9755-7A8FDDE554DB@gmail.com> To: Kyle Evans X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 28E3E8B1F1 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 21:51:21 -0000 > On Feb 28, 2019, at 1:47 PM, Kyle Evans wrote: >=20 > On Thu, Feb 28, 2019 at 3:44 PM Enji Cooper = wrote: >>=20 >>=20 >>> On Feb 28, 2019, at 12:48 PM, Bryan Drewery = wrote: >>>=20 >>> Author: bdrewery >>> Date: Thu Feb 28 20:48:18 2019 >>> New Revision: 344666 >>> URL: https://svnweb.freebsd.org/changeset/base/344666 >>>=20 >>> Log: >>> bsd.nls.mk isn't optional. >>>=20 >>> It is protected by MK_NLS. If it should really be optional then ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ To paraphrase Faith No More=E2=80=99s - = Epic: =E2=80=9Cwhat is =E2=80=98It=E2=80=99?" = ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > If we actually conditionally installed it, sure- it was only removed > because of r335011, so it would go through an install/remove dance > between installworld and delete-old on WITHOUT_NLS systems. Oh=E2=80=A6 you=E2=80=99re right. The commit message mislead me to think = that it was conditionally installed, but it=E2=80=99s actually always = installed. > If we're going to make it conditional on MK_NLS, it needs to actually > be conditional on MK_NLS the proper way along with an > s/.include/.sinclude/. This is what I was implying ;)=E2=80=A6 Cheers, -Enji