From owner-freebsd-current Fri Oct 4 17:43:20 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AFA9137B401; Fri, 4 Oct 2002 17:43:18 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3148443E6A; Fri, 4 Oct 2002 17:43:17 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 0BD6481432; Sat, 5 Oct 2002 10:13:15 +0930 (CST) Date: Sat, 5 Oct 2002 10:13:15 +0930 From: Greg 'groggy' Lehey To: Robert Watson Cc: Terry Lambert , Emiel Kollof , Peter Wemm , Poul-Henning Kamp , n0go013 , current Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost Message-ID: <20021005004315.GV72541@wantadilla.lemis.com> References: <20021005002350.GR72541@wantadilla.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Friday, 4 October 2002 at 20:29:51 -0400, Robert Watson wrote: > > On Sat, 5 Oct 2002, Greg 'groggy' Lehey wrote: > >> FWIW, I've never seen this code. The dates on the patch suggest that >> it was made in the last quarter of an hour: > > I didn't claim that this was his code. This was code I just wrote to > address Vinum not finding the devices due to major/minor number > changes. Ah, then I misunderstood. Sorry. > I was referring to a separate problem involving a zero'd sectorsize > resulting in a divide by zero in the kernel, which Jeff reported > experiencing and fixing previously. Ah, yes, I recall seeing that one, I think. >>> --- vinumio.c 21 Aug 2002 23:39:51 -0000 1.75 >>> +++ vinumio.c 5 Oct 2002 00:03:09 -0000 >> >> However: >> >> RCS file: /home/ncvs/src/sys/modules/vinum/Makefile,v >> revision 1.18 >> date: 2000/04/16 00:17:46; author: grog; state: Exp; lines: +1 -3 >> Remove MAINTAINER. >> >> Since that point, this particular file has had 5 updates, only one from >> me. Jeff's a committer; he can commit it himself if he wants. > > Hmm. Funny, I was paying more attention to the line in the MAINTAINER's > file which seems to suggest you are the maintainer. :-) No, I just suggest that people bounce things off me before committing: vinum grog Recommends pre-commit review. > Given that you appear to have read this patch -- may I commit it > since it appears to resolve the first of the nits I ran into using > Vinum with GEOM? Sure, you don't need my permission. But let me look at it more carefully. As I said, I have a number of changes which also get rid of this mess, and which were never committed. Let me take a look and get back to you. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message