From owner-cvs-all  Mon May 18 14:07:23 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id OAA04595
          for cvs-all-outgoing; Mon, 18 May 1998 14:07:23 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from gvr.gvr.org (guido@gvr.gvr.org [194.151.74.97])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA04380;
          Mon, 18 May 1998 14:06:33 -0700 (PDT)
          (envelope-from guido@gvr.org)
Received: (from guido@localhost)
	by gvr.gvr.org (8.8.8/8.8.5) id XAA08920;
	Mon, 18 May 1998 23:06:22 +0200 (MET DST)
From: Guido van Rooij <guido@gvr.org>
Message-Id: <199805182106.XAA08920@gvr.gvr.org>
Subject: Re: cvs commit: src/sys/netinet tcp_input.c
In-Reply-To: <199805182054.GAA30065@godzilla.zeta.org.au> from Bruce Evans at "May 19, 98 06:54:52 am"
To: bde@zeta.org.au (Bruce Evans)
Date: Mon, 18 May 1998 23:06:22 +0200 (MET DST)
Cc: guido@FreeBSD.ORG, jhay@mikom.csir.co.za, cvs-committers@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL32 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Bruce Evans wrote:
> >> guido       1998/05/18 10:07:59 PDT
> >> 
> >>   Modified files:
> >>     sys/netinet          tcp_input.c 
> >>   Log:
> >>   Add some parenthesis for clarity and fix a bug
> >>   Pointed out by: Garrett Wollmand
> >                                   ^
> >Shouldn't you also add this to rc.network so that it can start
> >automatically on new machines? :-)
> 
> Then you should also add the bd :-).  It deletes parentheses for
> clarity.  Its review of this patch: "2 extra layers of parentheses
> is 2 more layers than I would use and 1 more layer than KNF.  This
> change has no affect on the object code.  Where is the bug fix?".
> 

See the next commit (t_state -> t_flags). The whole commit would not
have been done if it wasn't for the bugfix. Somehow that got left out :-(

Somehow, I suspect the bd to automatically send email to every commit,
randomly poking at parts from the commit and throwing a couple of "there's
a style bug in there" to you. When assembly is involved, it usually also
magically comes up with the amount of clock cycles the change adds.
The funny thing is, that the comments are mostly true....

-Guido

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message