From owner-cvs-all Wed Dec 15 6: 2:29 1999 Delivered-To: cvs-all@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id 25E281525B; Wed, 15 Dec 1999 06:02:19 -0800 (PST) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.1/8.9.1) with ESMTP id JAA23456; Wed, 15 Dec 1999 09:02:16 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.9.3/8.9.1) id JAA15827; Wed, 15 Dec 1999 09:01:45 -0500 (EST) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Wed, 15 Dec 1999 09:01:45 -0500 (EST) To: Matt Dillon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfs nfs_serv.c In-Reply-To: <199912131734.JAA02524@freefall.freebsd.org> References: <199912131734.JAA02524@freefall.freebsd.org> X-Mailer: VM 6.43 under 20.4 "Emerald" XEmacs Lucid Message-ID: <14423.40355.215768.533614@grasshopper.cs.duke.edu> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Matt Dillon writes: > dillon 1999/12/13 09:34:45 PST <..> > > Revision Changes Path > 1.90 +78 -2 src/sys/nfs/nfs_serv.c This introduces a 32/64-bit problem on alphas: cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I../.. -I/usr/include -DKERNEL -include opt_global.h -D_KERNEL -mno-fp-regs -Wa,-mev56 ../../nfs/nfs_serv.c ../../nfs/nfs_serv.c: In function `nfsrv_read': ../../nfs/nfs_serv.c:874: warning: cast from pointer to integer of different size How about casting to a vm_offset_t? Eg: Index: nfs_serv.c =================================================================== RCS file: /home/ncvs/src/sys/nfs/nfs_serv.c,v retrieving revision 1.90 diff -u -r1.90 nfs_serv.c --- nfs_serv.c 1999/12/13 17:34:45 1.90 +++ nfs_serv.c 1999/12/15 13:59:31 @@ -871,7 +871,7 @@ * Locate best candidate */ - hi = ((int)vp / sizeof(struct vnode)) & (NUM_HEURISTIC - 1); + hi = ((vm_offset_t)vp / sizeof(struct vnode)) & (NUM_HEURISTIC - 1); nh = &nfsheur[hi]; while (try--) { I don't have any FreeBSD/Alpha NFS servers, so this is untested. Cheers, Drew ------------------------------------------------------------------------------ Andrew Gallatin, Sr Systems Programmer http://www.cs.duke.edu/~gallatin Duke University Email: gallatin@cs.duke.edu Department of Computer Science Phone: (919) 660-6590 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message