From owner-freebsd-current Tue Mar 6 9: 2:24 2001 Delivered-To: freebsd-current@freebsd.org Received: from blizzard.sabbo.net (blizzard.sabbo.net [193.193.218.18]) by hub.freebsd.org (Postfix) with ESMTP id 99CA537B719 for ; Tue, 6 Mar 2001 09:02:10 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112]) by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f26H1IM26474; Tue, 6 Mar 2001 19:01:26 +0200 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vic.sabbo.net (8.11.2/8.11.2) with ESMTP id f26H1RG50988; Tue, 6 Mar 2001 19:01:27 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3AA517D8.3AE21660@FreeBSD.org> Date: Tue, 06 Mar 2001 19:01:13 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.76 [en] (WinNT; U) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: Poul-Henning Kamp Cc: Warner Losh , igorr@crosswinds.net, freebsd-current@FreeBSD.org Subject: Re: Correct size of kinfo_proc References: <9377.983896057@critter> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 8bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > In message <3AA50F01.6560C34A@FreeBSD.org>, Maxim Sobolev writes: > >Warner Losh wrote: > > > >> In message <20010228161009.B14235@linux.rainbow> Igor Robul writes: > >> : On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote: > >> : > Hi Poul, > >> : > > >> : > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to > >> : > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE from 644 to 648. > >> : > Please correct. > >> : Why don't use sizeof() insead of hardcoding numbers? > >> > >> Because KINFO_PROC_SIZE is part of the ABI. Changes to its size are > >> always wrong, in that they break the ABI. The checks are there to > >> tell us when the ABI has been broken. > > > >Well, we are now well informed about this, could we just fix sys/sys/user.h to match > >relity (credit goes to phk for broking it and ignoring my posts completely)? > > I've been kind of waiting for -current to actually work again. I hate > commiting to -current when it's bÆrked. > > Yes, fix it in for now, or better, do the right thing > with version numbers. Ah ok if so, I though that you just forgot about it. I think it would be wise for me to avoid hacking this part, especially considering that the only harm from this is warning message at bootup. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message