From nobody Tue Jul 28 19:47:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8mFL4RKdz6nCFV for ; Tue, 28 Jul 2026 19:47:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8mFL1cZhz48J2 for ; Tue, 28 Jul 2026 19:47:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785268022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KgAN+Vv9K03snsrFdcRpXDZpciygaTLouBdwDoScPcg=; b=oWIaXIzav0jm1AG2r7b2oMfrhr8/9Hv70eI0EpKjX0n6JQwlcghBIrLdVxH4bEAd/ykmCk +QM+NEI3HegxiK/6pmdT0WwPcJc7y0em6dHVqC/P8AISqzd2NlIm1fYCHA3EX1yevthrc8 rWTmlWXQurmctkq9NFMNAA0uZbXPw0tTJ746tC2DI5PpoB+aJe00chwq6YhXOvT+h15IPb G73DEEkXoHAvxIRRGapFOAd23+HbcEFqaDLrGToH9AfgYXBzmK7eh0/ec1mvNT8dVNddda hGdEis55q0d6jnz0hHllFiOr9eXN7sdVzwGQfRFNTXYdnkCyRj2C0BGtHmnQ3Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785268022; a=rsa-sha256; cv=none; b=hhqKeTpqw5KnO2WPCPqsSvFP9IbZETG/lL53GuF97biiNisSvs+LFzFykq7xuqveklasoE meiXN64wd3unjZIdxPDR9FOipjlsR3tiZxocn4Z6nwnpxWh+XkLFH+0tnfTyvYmwP85tsK 5vKCY3dDvJ5ThX9KXhpwzCVM1rOwo8H8IMMoJy7JihHUghCHSKjvPUCCGmnvyMn9Q4LNzn Pg6aLGG6DhE5qyL+gqBFkHLaccJVwv6mr6IIBXeqgzYR3tZpk6ppOKZ3telFLPciSO70dc n4sm00pLoBbH7fIQ3ZXk0DpymOkYIqYOY9734QEwwdaTH3mLxfmk8BeCoQ+Kiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785268022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KgAN+Vv9K03snsrFdcRpXDZpciygaTLouBdwDoScPcg=; b=FgsRXs40pVe/1qPrvOmSjth4jqUfMlpBpmeiJI3cr6tlvKw7CAa9V2/Hh5Ko0zzcl69xNt +Uu1bRmeuLXCt/vumtwXhulzp6+Pgx58oGFYm06+hTijfu8Gv61lg3dLqvTkpMFZtRQ/Qn rRMxItJgTgdZPN74aj5gea/J7eQIEBIstbgvF4bc1hiK9IC+7Js48glEBswPTMYQyDyWUn 0/jjRT/pdpbJFQnvTtAaqV+1lMOVnlPpAiwJq67fEN5V/tjT/EcfyKgKGuV16pfCrUg6wN +eTM/m+v/9ra3zHZCRwRFPEMi4Ksg7kDyYFty9D5QWlndMSaoztlXZDY+Oo31w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h8mFL0F8QztvF for ; Tue, 28 Jul 2026 19:47:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 460e2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Jul 2026 19:47:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 2e259c209f69 - main - kern_pdwait(): print the process pointer through pd List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2e259c209f6912bc99e18bbfb55dd10554b3b11d Auto-Submitted: auto-generated Date: Tue, 28 Jul 2026 19:47:02 +0000 Message-Id: <6a690736.460e2.28a1b3b7@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=2e259c209f6912bc99e18bbfb55dd10554b3b11d commit 2e259c209f6912bc99e18bbfb55dd10554b3b11d Author: Konstantin Belousov AuthorDate: 2026-07-27 23:37:44 +0000 Commit: Konstantin Belousov CommitDate: 2026-07-28 19:45:52 +0000 kern_pdwait(): print the process pointer through pd to avoid using uninitialized value in the KASSERT() statement on the first iteration. Also, do the assert under the proctree_lock, which is not critical but satisfies the invariants. Noted and reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D58505 --- sys/kern/kern_exit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c index c43bd69554e7..ebe4aa40c128 100644 --- a/sys/kern/kern_exit.c +++ b/sys/kern/kern_exit.c @@ -1572,12 +1572,12 @@ kern_pdwait(struct thread *td, int fd, int *status, goto exit_unlocked; for (;;) { + sx_xlock(&proctree_lock); /* We own a reference on the procdesc file. */ KASSERT(pd->pd_fpcount > 0, ("closed proc %p procdesc %p pd flags %#x", - p, pd, pd->pd_flags)); + pd->pd_proc, pd, pd->pd_flags)); - sx_xlock(&proctree_lock); p = pd->pd_proc; if (p == NULL) { error = ESRCH;