Date: Wed, 26 Aug 1998 15:22:12 +0200 (CEST) From: p@i609.hadiko.de (Philipp Mergenthaler) To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: misc/7748: sysinstall doesn't unmount CDROM on exiting; patch included Message-ID: <199808261322.PAA07432@i609.hadiko.de>
next in thread | raw e-mail | index | archive | help
>Number: 7748
>Category: misc
>Synopsis: sysinstall doesn't unmount CDROM on exiting; patch included
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Aug 26 06:30:01 PDT 1998
>Last-Modified:
>Originator: Philipp Mergenthaler
>Organization:
>Release: FreeBSD 3.0-CURRENT i386
>Environment:
-current sources, "cvsupped" on 1998/08/26,
/usr/src/release/sysinstall%ident cdrom.c
cdrom.c:
$Id: cdrom.c,v 1.41 1998/07/21 06:44:38 jkh Exp $
>Description:
Sysinstall doesn't unmount the CDROM (when it has been chosen
as installation medium), but leaves it mounted on /dist .
This is caused by the variable cdromMounted not being set to
TRUE when the CDROM is mounted in the function mediaInitCDROM.
The assignement to this variable is in the wrong branch of an
if-statement. The function mediaShutdownCDROM relies on this variable.
>How-To-Repeat:
Start /stand/sysinstall, choose "Configure", choose "Media",
choose "CDROM", choose "Packages". Quit sysinstall. Now
"mount" shows, that the CDROM is still mounted on /dist .
>Fix:
--- cdrom.c Wed Aug 26 13:53:30 1998
+++ cdrom.c.fixed Wed Aug 26 14:01:57 1998
@@ -84,8 +84,9 @@
msgConfirm("Error mounting %s on %s: %s (%u)", dev->devname, mountpoint, strerror(errno), errno);
return FALSE;
}
- cdromMounted = TRUE;
}
+ else
+ cdromMounted = TRUE;
if (!file_readable(string_concat(mountpoint, "/cdrom.inf")) && !bogusCDOK) {
if (msgYesNo("Warning: The CD currently in the drive is either not a FreeBSD\n"
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808261322.PAA07432>