From owner-cvs-all@FreeBSD.ORG Wed Feb 7 23:44:46 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0A47D16A406; Wed, 7 Feb 2007 23:44:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 7EC0613C4B6; Wed, 7 Feb 2007 23:44:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l17NiVI5082670; Wed, 7 Feb 2007 18:44:31 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Nate Lawson Date: Wed, 7 Feb 2007 18:44:48 -0500 User-Agent: KMail/1.9.1 References: <2107.1170888121@critter.freebsd.dk> <20070207225651.T23167@fledge.watson.org> <45CA60F7.4000507@root.org> In-Reply-To: <45CA60F7.4000507@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200702071844.49532.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 07 Feb 2007 18:44:34 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2533/Wed Feb 7 09:20:47 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Marcel Moolenaar , cvs-src@freebsd.org, cvs-all@freebsd.org, Poul-Henning Kamp , src-committers@freebsd.org, Robert Watson Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf EP80219 src/sys/conf NOTES files files.powerpc options src/sys/geom geom_apple.c geom_gpt.c src/sys/geom/part g_part.c g_part.h g_part_apm.c g_part_gpt.c g_part_if.m src/sys/i386/conf GENERIC ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2007 23:44:46 -0000 On Wednesday 07 February 2007 18:29, Nate Lawson wrote: > Robert Watson wrote: > > > > On Wed, 7 Feb 2007, Poul-Henning Kamp wrote: > > > >> In message <20070207200130.J23167@fledge.watson.org>, Robert Watson > >> writes: > >> > >>>> The ctlreq interface supports verbs to create and destroy > >>>> partitioning schemes on a disk; to add, delete and modify > >>>> partitions; and to commit or undo changes made. > >>> > >>> Does this mean we can expect to see the disabling of GEOM > >>> exclusive-use protections disappear from normal administrative > >>> activities soon, as there will now be approved channels to > >>> incrementally change the layout of in-use partition tables? > >> > >> There is already a mechanism for that. How do you think bsdlabel(8) > >> and fdisk(8) works ? > > > > I understand that. This was a pragmatic question rather than a > > philosophical question: I know it can be done, but is it now being > > done. The answer appears to be yes. > > I assume phk@ is referring to the geom debug flags sysctl. The problem > with that approach is that it disabled (and potentially left disabled if > the flag wasn't cleared as the tool exits) all protection for the > devnode behind the mounted drive. If something else was running at the > same time, it could overwrite any data on the devnode. Or the fdisk > tool could write anywhere in the device, not just the boot sector. No, fdisk and bsdlabel don't frob the sysctl, they talk directly to GEOM to update the stuff as well using MBR-specific or BSD label-specific requests. -- John Baldwin