From owner-cvs-all@FreeBSD.ORG Sun Sep 28 20:59:11 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E5FB1065686; Sun, 28 Sep 2008 20:59:11 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 31AA78FC1B; Sun, 28 Sep 2008 20:59:11 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 2872F28449; Mon, 29 Sep 2008 04:59:10 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 75187F681F2; Mon, 29 Sep 2008 04:59:09 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id 526Bd6P-iE+t; Mon, 29 Sep 2008 04:59:04 +0800 (CST) Received: from delta.delphij.net (c-76-103-40-85.hsd1.ca.comcast.net [76.103.40.85]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 818A3F681B8; Mon, 29 Sep 2008 04:59:02 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=Y4rfIoDAVvnMLeQDhcDKHMYdMKhwiFLG4YTZvrPHLb5rlRWN66HwWJ2knRDjoMH1W P4QCmah2a3soYqOUtUx9w== Message-ID: <48DFF013.3080309@delphij.net> Date: Sun, 28 Sep 2008 13:58:59 -0700 From: Xin LI Organization: The Geek China Organization User-Agent: Thunderbird 2.0.0.17 (X11/20080926) MIME-Version: 1.0 To: Kostik Belousov References: <200809270009.m8R09OTF000738@repoman.freebsd.org> <20080927084606.GZ47828@deviant.kiev.zoral.com.ua> <48DFE13E.2030200@delphij.net> <20080928203210.GA2433@deviant.kiev.zoral.com.ua> In-Reply-To: <20080928203210.GA2433@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Xin LI , src-committers@FreeBSD.ORG, d@delphij.net, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/init init.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Sep 2008 20:59:11 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kostik Belousov wrote: > On Sun, Sep 28, 2008 at 12:55:42PM -0700, Xin LI wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Kostik Belousov wrote: >>> On Sat, Sep 27, 2008 at 12:09:10AM +0000, Xin LI wrote: >>>> delphij 2008-09-27 00:09:10 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sbin/init init.c >>>> Log: >>>> SVN rev 183391 on 2008-09-27 00:09:10Z by delphij >>>> >>>> Static-ify procedures in init(8). >>>> >>>> Revision Changes Path >>>> 1.66 +79 -79 src/sbin/init/init.c >>> What is a reason for the change ? >> This would reduce the size of generated binary... > > I am quite curious. Could you, please, show the numbers. > Is the reduction in size is due to function inlining, or it is purely > symbol table size issue ? Oh it's not purely symbol table size, making these stuff static would reduce instructions by 100+ for this case. If we strip all symbols out then we still have a 2KB saving by doing this. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkjf8BMACgkQi+vbBBjt66B1nwCffDVNCGXBm6cqWwfcyrUSvbMA NgwAnijd7Ya4k3MmiuH7VhDyh9KmPMhc =K5Hc -----END PGP SIGNATURE-----