From owner-svn-src-head@freebsd.org  Thu Jun 14 02:14:16 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F333E10122BA
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Thu, 14 Jun 2018 02:14:15 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A36EF6B0DD
 for <svn-src-head@freebsd.org>; Thu, 14 Jun 2018 02:14:15 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: from mail-yb0-f181.google.com (mail-yb0-f181.google.com
 [209.85.213.181])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: eadler)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 6B006AB2F
 for <svn-src-head@freebsd.org>; Thu, 14 Jun 2018 02:14:15 +0000 (UTC)
 (envelope-from eadler@freebsd.org)
Received: by mail-yb0-f181.google.com with SMTP id m137-v6so1671960ybm.6
 for <svn-src-head@freebsd.org>; Wed, 13 Jun 2018 19:14:15 -0700 (PDT)
X-Gm-Message-State: APt69E1CEAaeAIAwTg9pBTOEnEMkzYTABAqve03gfIgLTKKMy5ofkPVe
 rqQx846TFOOLbE4E5YlGdQ7pHqG3h7tzNpx75Dul5g==
X-Google-Smtp-Source: ADUXVKI/WOtH3MpRNejxBE4GMtJOa3g7pFqPMLK+L5gUigov/DwCx1rsnA2wWMcVr2r5kkB8p1SQt90gluB6YoGQ1AQ=
X-Received: by 2002:a25:8751:: with SMTP id
 e17-v6mr357206ybn.194.1528942454839; 
 Wed, 13 Jun 2018 19:14:14 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 19:13:44
 -0700 (PDT)
In-Reply-To: <b03b8a00-e14d-b670-e5b7-b105a9eb5d2a@freebsd.org>
References: <201806020325.w523PFKn048824@repo.freebsd.org>
 <b03b8a00-e14d-b670-e5b7-b105a9eb5d2a@freebsd.org>
From: Eitan Adler <eadler@freebsd.org>
Date: Wed, 13 Jun 2018 19:13:44 -0700
X-Gmail-Original-Message-ID: <CAF6rxgmZNVDb3qpYrK3cZAGxLQxv1FLeH8S3XcMy1ps-O-8r1A@mail.gmail.com>
Message-ID: <CAF6rxgmZNVDb3qpYrK3cZAGxLQxv1FLeH8S3XcMy1ps-O-8r1A@mail.gmail.com>
Subject: Re: svn commit: r334514 - head/usr.bin/top
To: Allan Jude <allanjude@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 02:14:16 -0000

On 13 June 2018 at 17:10, Allan Jude <allanjude@freebsd.org> wrote:
>
> This broke compressed ARC display in top. The sysctl
> vfs.zfs.compressed_arc_enabled is backed by a boolean_t (which is the
> same size as an int), so trying to read it into a bool (1 byte) fails
> and returns ENOMEM.
>
> Fixed in r335099

Sorry for the breakage and thanks for the fix. As discussed on IRC,
the type of the sysctl might change to int (from boolean_t) and we
don't have a great way of asserting that the size is right.



-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams