Date: Wed, 13 Jun 2018 19:13:44 -0700 From: Eitan Adler <eadler@freebsd.org> To: Allan Jude <allanjude@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334514 - head/usr.bin/top Message-ID: <CAF6rxgmZNVDb3qpYrK3cZAGxLQxv1FLeH8S3XcMy1ps-O-8r1A@mail.gmail.com> In-Reply-To: <b03b8a00-e14d-b670-e5b7-b105a9eb5d2a@freebsd.org> References: <201806020325.w523PFKn048824@repo.freebsd.org> <b03b8a00-e14d-b670-e5b7-b105a9eb5d2a@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 June 2018 at 17:10, Allan Jude <allanjude@freebsd.org> wrote: > > This broke compressed ARC display in top. The sysctl > vfs.zfs.compressed_arc_enabled is backed by a boolean_t (which is the > same size as an int), so trying to read it into a bool (1 byte) fails > and returns ENOMEM. > > Fixed in r335099 Sorry for the breakage and thanks for the fix. As discussed on IRC, the type of the sysctl might change to int (from boolean_t) and we don't have a great way of asserting that the size is right. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmZNVDb3qpYrK3cZAGxLQxv1FLeH8S3XcMy1ps-O-8r1A>