From owner-svn-src-head@FreeBSD.ORG Fri Jan 2 21:45:36 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A56C23BD; Fri, 2 Jan 2015 21:45:36 +0000 (UTC) Received: from mail-ie0-x229.google.com (mail-ie0-x229.google.com [IPv6:2607:f8b0:4001:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62B4866981; Fri, 2 Jan 2015 21:45:36 +0000 (UTC) Received: by mail-ie0-f169.google.com with SMTP id y20so17286733ier.0; Fri, 02 Jan 2015 13:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=qIyfcFPSREGYkZjfxux9FEeNsNsHJ+5UlCDgg03jxUI=; b=uN2L/BKxqWZF/R/zbo717gG7IxSRQUjkYa3tT3J/Ac2G8lc4OBRY0c0HT+7lUGM8Q7 GR2vaa2YQSAVY8XT+7YwQruy2P7VjrFRFQtH1vMRpS+K6k2aC7RFIZ2/+T6D9R5jEe3G uzK/JCT2cYWvCZX9KfLR/IwAr24WSY+lHlbeV0sGlIFVomveZWZ5XGveqgQOiCrovums /BpQqB7g0tEhQd+13hIpNms2Ud2v2TJzdRJutC/ATUoNeh+x6FJAbzm3GQjAA+DOm57n UjNzsqpeG7odjyjwx7qK/5y1oah3GJVjX34y/1LfVbeJR1VOjInimmSiP4O5wfpF8qYb K7EA== X-Received: by 10.50.66.198 with SMTP id h6mr827952igt.22.1420235135666; Fri, 02 Jan 2015 13:45:35 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.0.85 with HTTP; Fri, 2 Jan 2015 13:45:15 -0800 (PST) In-Reply-To: <201501022049.t02Kni1P036850@svn.freebsd.org> References: <201501022049.t02Kni1P036850@svn.freebsd.org> From: Ed Maste Date: Fri, 2 Jan 2015 16:45:15 -0500 X-Google-Sender-Auth: fy441JwTK_48PTtG_ZEKkORFIi4 Message-ID: Subject: Re: svn commit: r276567 - head/contrib/elftoolchain/readelf To: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jan 2015 21:45:36 -0000 On 2 January 2015 at 15:49, Ed Maste wrote: > Author: emaste > Date: Fri Jan 2 20:49:43 2015 > New Revision: 276567 > URL: https://svnweb.freebsd.org/changeset/base/276567 > ... > +#if 0 > case NT_AUXV: > return "NT_AUXV (Auxiliary vector)"; Oops, the #if 0s here were unintentionally included in the commit. It is currently needed to build elftoolchain's readelf though, as the set of NT_ defines here are actually Linux ones. In fact, readelf's note parsing does not properly support multiple operating systems right now: http://sourceforge.net/p/elftoolchain/tickets/473/ This is fairly easily addressed, and will replace this #if 0'd code later on.