From owner-dev-commits-ports-all@freebsd.org Tue May 18 20:30:40 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E77DF656D5D; Tue, 18 May 2021 20:30:40 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fl71D4cPHz4tSY; Tue, 18 May 2021 20:30:40 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-156-34-187-65.dhcp-dynamic.fibreop.ns.bellaliant.net [156.34.187.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 40AF6621C; Tue, 18 May 2021 20:30:40 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6464fe05fe9d - main - - Update Unipro UGENE to version 38.1 and thus unbreak - CONFIG defaults to 64-bit mode now, adjust the check References: <202105181525.14IFPYMT003113@gitrepo.freebsd.org> <86pmxo56wi.fsf@phe.ftfl.ca> Date: Tue, 18 May 2021 17:30:39 -0300 In-Reply-To: (Alexey Dokuchaev's message of "Tue, 18 May 2021 20:09:49 +0000") Message-ID: <868s4b6az4.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 20:30:41 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 2021-05-18 at 20:09, Alexey Dokuchaev wrote: > On Tue, May 18, 2021 at 01:43:57PM -0300, Joseph Mingrone wrote: >> ... >> Here are some snippets of what can be seen with git log --oneline. > It's a known bug in Git, for some reason it does not stop at first \n. > Interestingly, cgit web frontend does not exhibit this problem, does > it use some smarter form of shortlog? > The main point, however, is that commit logs should not contain what > can be easily and automatically inferred from the commit itself. As > an example of sanity, have a look at https://freshbsd.org/freebsd, > which infers correct commit headers and clearly shows how needlessly > noisy those "canonical" logs start to look like if you do things the > right way. > ./danfe The FreshBSD page seems to be showing full commit logs. I don't know how cgit implements their log display, but it's not a bug. It's a convention. See GIT-COMMIT(1). Though not required, it=E2=80=99s a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. The text up to the first blank line in a commit message is treated as the commit title, and that title is used throughout Git. For example, git-format-patch(1) turns a commit into email, and it uses the title on the Subject line and the rest of the commit in the body. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmCkI+9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnvcED/40m8o9vcGpNIrZs/xigmdTanwLGyyJcale /IwNetlcFxC16hQH5D0QSQqXuTenW90FOtO+NSXdX2k4K0QCZSVLyhHUymqZJu9C rsxdWAM938gcDYF3fCRLKlvi6IfnjczHHs4Pqmq0YSZP3k7AWziZjgbpooh6Ocpu 51a3RPu7Ro3TwTPRcm0a7IaDAje62CjgojkmcklKGOhgVY9HNqe+tWpGbubjf3An 4AmARxOrPg4KIPbRFMgrERqrEsS5uveTJY4FE4IdoG8fBM1FNWzl+3e/rvV6kMl6 4UBSqq+4nfl2mLoSZkl9vi8+laYnJxB5C1jPQO8uqQulS6M9MMz2qtEavn8uJQDw KsxjTxEJTEdsAFVEX6j4eL2j28B3P606XCVjuMJaJQKrJ3cmIQy9uYnyBZYPMIq7 tJccb1jd93Ew4DkmEGijvsHhfTXj4jVEsfQA83CViRFXRKwp/1QMiUu3dsURthit Tp8C9sWwunXXZ1wis8ijD2oY3b7ChyWxaACXjP7TExzYvz4c3FVx+NmrxY+iMS0p v78QCxHB96bI8h5IA++WNu37GRmX0m0SY+5RS9yIYE+OF1/28qaoeen7bvv1LIlq Bu/g8y1o0XGPIKF79Strg7Co+Sle4nIp/T9FayK338IfLmgcGvu5V9UBBPSslK6E 8324zHXh5g== =Tjpa -----END PGP SIGNATURE----- --=-=-=--