From owner-freebsd-current@FreeBSD.ORG Mon Jun 8 08:47:47 2009 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77FA410656DD; Mon, 8 Jun 2009 08:47:47 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (unknown [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id F36958FC28; Mon, 8 Jun 2009 08:47:46 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p3185-ipbf514funabasi.chiba.ocn.ne.jp [123.225.96.185]) (authenticated bits=128) by mail.allbsd.org (8.14.3/8.14.3) with ESMTP id n588jVLf020690; Mon, 8 Jun 2009 17:45:42 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id n588jK3t068988; Mon, 8 Jun 2009 17:45:21 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 08 Jun 2009 17:44:50 +0900 (JST) Message-Id: <20090608.174450.250237255.hrs@allbsd.org> To: rea-fbsd@codelabs.ru From: Hiroki Sato In-Reply-To: References: <20090608.165325.225640915.hrs@allbsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.2.51 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Jun__8_17_44_50_2009_039)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (mail.allbsd.org [133.31.130.32]); Mon, 08 Jun 2009 17:45:42 +0900 (JST) Cc: amd64@FreeBSD.org, current@FreeBSD.org Subject: Re: [head tinderbox] failure on amd64/amd64 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 08:47:48 -0000 ----Security_Multipart(Mon_Jun__8_17_44_50_2009_039)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eygene Ryabinkin wrote in : re> Do you intend to set sc->gif_options only for the case of failed re> copyin()? This looks a bit strange to me too, because re> 1. in this case 'options' will have undeterminate contents; re> 2. I thought that 'set options' should set options if it is re> permitted. re> Though there could be some logics behing this -- don't know, but re> may be the negation operator was lost before '(error = copyin(...))' -- re> this is most adequate description of check for GIF_FULLOPTS. Yea, you are right. '!' was missing at the head of the condition. The options should be updated when copyin() succeeds. Probably I need some sleep :| re> By the way, it will be great if new sysctls and their options will be re> documented somewhere, perhaps in the gif(4) itself. Okay, I think it is reasonable, too. I'll do. Thanks for the suggestion. -- Hiroki ----Security_Multipart(Mon_Jun__8_17_44_50_2009_039)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkosz4IACgkQTyzT2CeTzy3EUQCgznNEFpwCh6yCkbg+uZAs5m6q q2IAnij9WfyZTznMae7qDFC3CbXKcdvV =0tnq -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Jun__8_17_44_50_2009_039)----