From owner-dev-commits-src-all@freebsd.org Fri May 28 05:54:21 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89E0764C8DD; Fri, 28 May 2021 05:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Frv5T3XXWz3vHP; Fri, 28 May 2021 05:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 61BE712298; Fri, 28 May 2021 05:54:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 14S5sLpT016120; Fri, 28 May 2021 05:54:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 14S5sLQI016119; Fri, 28 May 2021 05:54:21 GMT (envelope-from git) Date: Fri, 28 May 2021 05:54:21 GMT Message-Id: <202105280554.14S5sLQI016119@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ram Kishore Vegesna Subject: git: dd722ccd6efc - main - ocs_fc: Fix a use after free in ocs_sport_free MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ram X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dd722ccd6efcaed5c6056e51a044db7f1a5b4a0d Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2021 05:54:21 -0000 The branch main has been updated by ram: URL: https://cgit.FreeBSD.org/src/commit/?id=dd722ccd6efcaed5c6056e51a044db7f1a5b4a0d commit dd722ccd6efcaed5c6056e51a044db7f1a5b4a0d Author: Ram Kishore Vegesna AuthorDate: 2021-05-28 05:26:13 +0000 Commit: Ram Kishore Vegesna CommitDate: 2021-05-28 05:26:13 +0000 ocs_fc: Fix a use after free in ocs_sport_free Domain which could be freed is used while freeing the sport. Use ocs from sport. PR: 255866 Reported by: lylgood@foxmail.com Approved by:: markj --- sys/dev/ocs_fc/ocs_sport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ocs_fc/ocs_sport.c b/sys/dev/ocs_fc/ocs_sport.c index 71fe350311f7..7df31b1448f1 100644 --- a/sys/dev/ocs_fc/ocs_sport.c +++ b/sys/dev/ocs_fc/ocs_sport.c @@ -263,7 +263,7 @@ ocs_sport_free(ocs_sport_t *sport) ocs_lock_free(&sport->node_group_lock); ocs_scsi_sport_deleted(sport); - ocs_free(domain->ocs, sport, sizeof(*sport)); + ocs_free(sport->ocs, sport, sizeof(*sport)); } }