From owner-freebsd-ports-bugs@freebsd.org Thu Nov 15 06:33:59 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B29C11280FA for ; Thu, 15 Nov 2018 06:33:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BE0D7856C5 for ; Thu, 15 Nov 2018 06:33:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8313311280F4; Thu, 15 Nov 2018 06:33:58 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6153811280F3 for ; Thu, 15 Nov 2018 06:33:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DC180856C2 for ; Thu, 15 Nov 2018 06:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 069FD185AB for ; Thu, 15 Nov 2018 06:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAF6Xuu0098938 for ; Thu, 15 Nov 2018 06:33:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAF6XuEL098937 for ports-bugs@FreeBSD.org; Thu, 15 Nov 2018 06:33:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 228596] [NEW PORT] finance/rippled: Reference server implementation of the Ripple protocol Date: Thu, 15 Nov 2018 06:33:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: BE0D7856C5 X-Spamd-Result: default: False [-105.91 / 200.00]; FORGED_RECIPIENTS_FORWARDING(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; FORWARDED(0.00)[ports-bugs@mailman.ysv.freebsd.org]; SPF_FAIL_FORWARDING(0.00)[]; TO_DN_NONE(0.00)[]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; XAW_SERVICE_ACCT(1.00)[]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-1.00)[-0.999,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.70)[ip: (-9.87), ipnet: 2001:1900:2254::/48(-4.81), asn: 10310(-3.75), country: US(-0.10)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[ports-bugs@FreeBSD.org,freebsd-ports-bugs@freebsd.org]; TO_DOM_EQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; FROM_NO_DN(0.00)[]; RCVD_COUNT_SEVEN(0.00)[7] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 06:33:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228596 --- Comment #1 from Tobias Kortkamp --- (In reply to waitman from comment #0) > should have at least 8GB RAM to build (according to rippled docs) So I guess I'm out in ever landing this. But here is a short review anyway: XMASTER_SITES=3D https://github.com/ripple/rippled/archive/ XDISTNAME=3D ${PORTVERSION} ... XWRKSRC=3D ${WRKDIR}/${PORTNAME}-${PORTVERSION} Please use USE_GITHUB and related variables here instead of GitHub's archive feature directly. XNO_ARCH=3D yes Huh? If the port builds binaries then this is probably wrong. X ${INSTALL} ${BUILD_WRKSRC}/rippled ${STAGEDIR}${PREFIX}/sbi= n/ Use INSTALL_PROGRAM. Also please fix the indentation here. X ${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.cfg ${STAGEDIR}${DOCS= DIR} X ${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.service ${STAGEDIR}${DOCSDIR} X ${INSTALL_DATA} ${WRKSRC}/cfg/rippled.init ${STAGEDIR}${DOCSDIR} X ${INSTALL_DATA} ${WRKSRC}/cfg/validators-example.txt ${STAGEDIR}${DOCSDIR} The *-example* files should probably be installed into EXAMPLESDIR (under an EXAMPLES option) instead. X @${CAT} ${WRKSRC}/MESSAGE What's the purpose of this? Nobody will see this message. It will be hidden in the build logs on the package builders. If this is a message for after the package has been installed, I suppose you could add PKGMESSAGE=3D ${WRKSRC}/MESSAGE to the port instead (then there is no point to also install it into DOCSDIR too). --=20 You are receiving this mail because: You are the assignee for the bug.=